Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add max_tablet_rowset_num metrcis #36539

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[Enhancement] Add max_tablet_rowset_num metrcis #36539

merged 1 commit into from
Dec 7, 2023

Conversation

decster
Copy link
Contributor

@decster decster commented Dec 6, 2023 •
edited
Loading

Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mergify mergify bot assigned decster Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

[BE Incremental Coverage Report]

❌ fail : 1 / 6 (16.67%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/tablet_manager.cpp 0 5 00.00% [920, 927, 942, 943, 944]
🔵 src/util/starrocks_metrics.cpp 1 1 100.00% []

@decster decster merged commit 555dfa6 into StarRocks:main Dec 7, 2023
46 of 48 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Dec 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

@Mergifyio backport branch-3.1

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

@Mergifyio backport branch-3.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Dec 7, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 7, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 7, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 7, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 7, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 7, 2023
@decster @mergify
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
4f8321d 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)

# Conflicts:
#	be/src/util/starrocks_metrics.cpp
@mergify mergify bot mentioned this pull request Dec 7, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 7, 2023
@decster @mergify
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
da0457f 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)

# Conflicts:
#	be/src/util/starrocks_metrics.cpp
@mergify mergify bot mentioned this pull request Dec 7, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 7, 2023
@decster @mergify
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
bc03f57 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)

# Conflicts:
#	be/src/util/starrocks_metrics.cpp
mergify bot pushed a commit that referenced this pull request Dec 7, 2023
@decster @mergify
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
646a647 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)

# Conflicts:
#	be/src/util/starrocks_metrics.cpp
@mergify mergify bot mentioned this pull request Dec 7, 2023
Merged
@mergify mergify bot mentioned this pull request Dec 7, 2023
Merged
decster added a commit that referenced this pull request Dec 7, 2023
@decster
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
076d192 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)
decster added a commit that referenced this pull request Dec 7, 2023
@decster
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
d255f03 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)
decster added a commit that referenced this pull request Dec 7, 2023
@decster
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
137adfb 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)
decster added a commit that referenced this pull request Dec 7, 2023
@decster
[Enhancement] Add max_tablet_rowset_num metrcis (#36539)
7857214 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)
decster added a commit that referenced this pull request Dec 7, 2023
@mergify @decster
[Enhancement] Add max_tablet_rowset_num metrcis (backport #36539) (#3…
5d1240e 
…6584)

Co-authored-by: Binglin Chang <[email protected]>
decster added a commit that referenced this pull request Dec 7, 2023
@mergify @decster
[Enhancement] Add max_tablet_rowset_num metrcis (backport #36539) (#3…
a974309 
…6583)

Co-authored-by: Binglin Chang <[email protected]>
decster added a commit that referenced this pull request Dec 7, 2023
@mergify @decster
[Enhancement] Add max_tablet_rowset_num metrcis (backport #36539) (#3…
9824a69 
…6582)

Co-authored-by: Binglin Chang <[email protected]>
decster added a commit that referenced this pull request Dec 7, 2023
@mergify @decster
[Enhancement] Add max_tablet_rowset_num metrcis (backport #36539) (#3…
8deadae 
…6581)

Co-authored-by: Binglin Chang <[email protected]>
dingxin-tech pushed a commit to dingxin-tech/starrocks-odps that referenced this pull request Dec 12, 2023
@decster @dingxin-tech
[Enhancement] Add max_tablet_rowset_num metrcis (StarRocks#36539)
7f660d2 
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes StarRocks#36469

Signed-off-by: Binglin Chang <[email protected]>
Signed-off-by: 鼎昕 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueeyu trueeyu trueeyu approved these changes

@luohaha luohaha luohaha approved these changes

Assignees

@decster decster

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a metrics about BE's tablets' max rowset count
4 participants
@decster @luohaha @trueeyu @wanpengfei-git