Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add max_tablet_rowset_num metrcis (backport #36539) #36584

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 7, 2023

This is an automatic backport of pull request #36539 done by Mergify.
Cherry-pick of 555dfa6 has failed:

On branch mergify/bp/branch-2.5/pr-36539
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 555dfa65b1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/storage/tablet_manager.cpp
	modified:   be/src/util/starrocks_metrics.h

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/util/starrocks_metrics.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Copy link
Contributor Author

mergify bot commented Dec 7, 2023

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-36539 branch December 7, 2023 02:02
@decster decster restored the mergify/bp/branch-2.5/pr-36539 branch December 7, 2023 02:15
@decster decster reopened this Dec 7, 2023
Why I'm doing:

Currently, it's hard to detect 'too many versions' error early, need a monitoring metrics.

What I'm doing:

Add a metric about BE's tablets' max rowset count, if this value continues increasing, it may indicate compaction is blocked or has issues, so adding a monitor for this value can detect too many version errors early.

Fixes #36469

Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit 555dfa6)
@decster decster force-pushed the mergify/bp/branch-2.5/pr-36539 branch from 646a647 to 7857214 Compare December 7, 2023 02:21
Copy link

github-actions bot commented Dec 7, 2023

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 7, 2023

[BE Incremental Coverage Report]

fail : 1 / 4 (25.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/tablet_manager.cpp 0 3 00.00% [899, 914, 915]
🔵 src/util/starrocks_metrics.cpp 1 1 100.00% []

@decster decster merged commit 5d1240e into branch-2.5 Dec 7, 2023
16 of 17 checks passed
@decster decster deleted the mergify/bp/branch-2.5/pr-36539 branch December 7, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants