[Enhancement] add config for lazy delta column compaction #36654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luohaha <[email protected]>
luohaha
force-pushed
the
add-lazy-delta-column-compact-config
branch
from
0b8dc3c
to
37162bd
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
decster
approved these changes
Dec 14, 2023
chaoyli
approved these changes
Dec 15, 2023
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: luohaha <[email protected]> (cherry picked from commit 0c726b6)
mergify bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: luohaha <[email protected]> (cherry picked from commit 0c726b6)
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 15, 2023
…36654) (#37111) Co-authored-by: Yixin Luo <[email protected]>
luohaha
added a commit
that referenced
this pull request
Dec 21, 2023
…36654) (#37110) Co-authored-by: Yixin Luo <[email protected]>
Zhangg7723
pushed a commit
to Zhangg7723/starrocks
that referenced
this pull request
Dec 26, 2023
…36654) Signed-off-by: luohaha <[email protected]> Signed-off-by: 张敢 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Lazy delta column compaction is designed for save compaction IO cost. We don't need to merge delta column back to segment too soon, because it doesn't affect query performance. But in some case, we don't want to keep too many delta column files so user can choose to close it.
What I'm doing:
add config
enable_lazy_delta_column_compactionfor lazy delta column compactionWhat type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: