Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] limit persistent index compaction by disk #36681

Merged
merged 1 commit into from
Dec 25, 2023
Merged

[Enhancement] limit persistent index compaction by disk #36681

merged 1 commit into from
Dec 25, 2023

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Dec 8, 2023 •
edited
Loading

Why I'm doing:
In current implementation, we doesn't control the compaction concurrency on one disk, which will cause compaction unbalanced between disks, and some disk's IO cost will be too high.

What I'm doing:

  1. Limit the disk compaction concurrency by config pindex_major_compaction_limit_per_disk .
  2. Refactor persistent index compaction scheduler code.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mergify mergify bot assigned luohaha Dec 8, 2023
@luohaha luohaha force-pushed the imrpove-pindex-compact branch 7 times, most recently from 53105ef to 3a63ce2 Compare December 11, 2023 00:18
@luohaha luohaha changed the title [Enhancement] schedule persistent index compaction by disk [Enhancement] limit persistent index compaction by disk Dec 11, 2023
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 27 / 35 (77.14%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/olap_server.cpp 0 3 00.00% [400, 402, 403]
🔵 src/http/action/update_config_action.cpp 0 2 00.00% [120, 121]
🔵 src/storage/persistent_index_compaction_manager.cpp 26 29 89.66% [67, 68, 80]
🔵 src/storage/persistent_index.cpp 1 1 100.00% []

@decster decster merged commit a44147f into StarRocks:main Dec 25, 2023
40 of 41 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Dec 25, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Dec 25, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Dec 25, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Dec 25, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 25, 2023
@luohaha @mergify
[Enhancement] limit persistent index compaction by disk (#36681)
1aed2d1 
Why I'm doing:
In current implementation, we doesn't control the compaction concurrency on one disk, which will cause compaction unbalanced between disks, and some disk's IO cost will be too high.

What I'm doing:

Limit the disk compaction concurrency by config pindex_major_compaction_limit_per_disk .
Refactor persistent index compaction scheduler code.

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit a44147f)

# Conflicts:
#	be/src/storage/persistent_index.h
#	be/src/storage/persistent_index_compaction_manager.cpp
#	be/test/storage/persistent_index_test.cpp
mergify bot pushed a commit that referenced this pull request Dec 25, 2023
@luohaha @mergify
[Enhancement] limit persistent index compaction by disk (#36681)
cc5f4f3 
Why I'm doing:
In current implementation, we doesn't control the compaction concurrency on one disk, which will cause compaction unbalanced between disks, and some disk's IO cost will be too high.

What I'm doing:

Limit the disk compaction concurrency by config pindex_major_compaction_limit_per_disk .
Refactor persistent index compaction scheduler code.

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit a44147f)

# Conflicts:
#	be/src/storage/persistent_index.h
#	be/src/storage/persistent_index_compaction_manager.cpp
This was referenced Dec 25, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Dec 25, 2023
@luohaha @mergify
[Enhancement] limit persistent index compaction by disk (#36681)
7d41425 
Why I'm doing:
In current implementation, we doesn't control the compaction concurrency on one disk, which will cause compaction unbalanced between disks, and some disk's IO cost will be too high.

What I'm doing:

Limit the disk compaction concurrency by config pindex_major_compaction_limit_per_disk .
Refactor persistent index compaction scheduler code.

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit a44147f)

# Conflicts:
#	be/src/storage/persistent_index.h
#	be/src/storage/persistent_index_compaction_manager.cpp
#	be/test/storage/persistent_index_test.cpp
@mergify mergify bot mentioned this pull request Dec 25, 2023
Merged
17 tasks
mergify bot pushed a commit that referenced this pull request Dec 25, 2023
@luohaha @mergify
[Enhancement] limit persistent index compaction by disk (#36681)
da01a85 
Why I'm doing:
In current implementation, we doesn't control the compaction concurrency on one disk, which will cause compaction unbalanced between disks, and some disk's IO cost will be too high.

What I'm doing:

Limit the disk compaction concurrency by config pindex_major_compaction_limit_per_disk .
Refactor persistent index compaction scheduler code.

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit a44147f)

# Conflicts:
#	be/src/storage/persistent_index_compaction_manager.cpp
#	be/test/storage/persistent_index_test.cpp
@mergify mergify bot mentioned this pull request Dec 25, 2023
Merged
17 tasks
luohaha added a commit that referenced this pull request Dec 25, 2023
@mergify @luohaha
[Enhancement] limit persistent index compaction by disk (backport #36681
fa348ca 
) (#37695)

Signed-off-by: Yixin Luo <[email protected]>
Co-authored-by: Yixin Luo <[email protected]>
luohaha added a commit that referenced this pull request Dec 25, 2023
@mergify @luohaha
[Enhancement] limit persistent index compaction by disk (backport #36681
7c6fa67 
) (#37694)

Signed-off-by: Yixin Luo <[email protected]>
Co-authored-by: Yixin Luo <[email protected]>
luohaha added a commit that referenced this pull request Dec 25, 2023
@mergify @luohaha
[Enhancement] limit persistent index compaction by disk (backport #36681
a86de94 
) (#37692)

Signed-off-by: Yixin Luo <[email protected]>
Co-authored-by: Yixin Luo <[email protected]>
luohaha added a commit that referenced this pull request Dec 25, 2023
@mergify @luohaha
[Enhancement] limit persistent index compaction by disk (backport #36681
954bceb 
) (#37693)

Signed-off-by: Yixin Luo <[email protected]>
Co-authored-by: Yixin Luo <[email protected]>
Zhangg7723 pushed a commit to Zhangg7723/starrocks that referenced this pull request Dec 26, 2023
@luohaha @Zhangg7723
[Enhancement] limit persistent index compaction by disk (StarRocks#36681
c31b16d 
)

Why I'm doing:
In current implementation, we doesn't control the compaction concurrency on one disk, which will cause compaction unbalanced between disks, and some disk's IO cost will be too high.

What I'm doing:

Limit the disk compaction concurrency by config pindex_major_compaction_limit_per_disk .
Refactor persistent index compaction scheduler code.

Signed-off-by: luohaha <[email protected]>
Signed-off-by: 张敢 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@sevev sevev sevev approved these changes

@decster decster decster approved these changes

Assignees

@luohaha luohaha

Labels
2.5-merged 3.0-merged 3.1-merged 3.2-merged backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luohaha @decster @sevev @wangruin