[Feature] Insert into parquet files support binary type #36797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
imay
reviewed
Dec 11, 2023
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
letian-jiang
approved these changes
Dec 12, 2023
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Smith-Cruise
approved these changes
Dec 12, 2023
dirtysalt
approved these changes
Dec 12, 2023
imay
approved these changes
Dec 12, 2023
|
@trueeyu @letian-jiang SR only support INSERT INTO FILES from 3.2, right? So, we needn't CP this PR to 3.0 or 3.1, right? |
AFAIK, branch 3.1 has implemented parquet writer. Thus, we can cp this PR to 3.1. |
|
https://github.com/Mergifyio backport branch-3.0 branch-3.1 branch-3.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: trueeyu <[email protected]> (cherry picked from commit 25b643a) # Conflicts: # be/src/formats/parquet/file_writer.cpp # be/src/formats/parquet/level_builder.cpp # be/src/formats/parquet/level_builder.h # be/test/formats/parquet/file_writer_test.cpp
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: trueeyu <[email protected]> (cherry picked from commit 25b643a)
17 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: trueeyu <[email protected]> (cherry picked from commit 25b643a)
This was referenced Dec 20, 2023
trueeyu
added a commit
that referenced
this pull request
Dec 21, 2023
) (#37448) Co-authored-by: trueeyu <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 21, 2023
) (#37447) Co-authored-by: trueeyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Current insert into files (parquet) don't support binary type, If i wan't to export bitmap, i should convert the binary type to base64. This is inconvenient to use and also will affect performance. So the pr will support binary type directly in insert into files.
What I'm doing:
Insert into parquet file select xxx from xxxsupport binary type directly.TestCase: https://github.com/StarRocks/StarRocksTest/pull/5138
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: