Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] add a switch to control default refresh immediate #37093

Merged
merged 1 commit into from
Dec 15, 2023
Merged

[Enhancement] add a switch to control default refresh immediate #37093

merged 1 commit into from
Dec 15, 2023

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Dec 15, 2023 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@murphyatwork murphyatwork requested a review from a team as a code owner December 15, 2023 00:29
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/Config.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@murphyatwork murphyatwork enabled auto-merge (squash) December 15, 2023 08:47
@murphyatwork murphyatwork merged commit 2bd50b9 into StarRocks:main Dec 15, 2023
81 of 91 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Dec 15, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Dec 15, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Dec 15, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Dec 15, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 15, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 15, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 15, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 15, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 15, 2023
@murphyatwork @mergify
[Enhancement] add a switch to control default refresh immediate (#37093)
0fb3b57 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 2bd50b9)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/Config.java
mergify bot pushed a commit that referenced this pull request Dec 15, 2023
@murphyatwork @mergify
[Enhancement] add a switch to control default refresh immediate (#37093)
c2a3d52 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 2bd50b9)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/Config.java
#	fe/fe-core/src/main/java/com/starrocks/sql/ast/RefreshSchemeDesc.java
mergify bot pushed a commit that referenced this pull request Dec 15, 2023
@murphyatwork @mergify
[Enhancement] add a switch to control default refresh immediate (#37093)
a5f702b 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 2bd50b9)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/Config.java
#	fe/fe-core/src/main/java/com/starrocks/sql/ast/RefreshSchemeDesc.java
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java
This was referenced Dec 15, 2023
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request Dec 15, 2023
@murphyatwork @mergify
[Enhancement] add a switch to control default refresh immediate (#37093)
3beffd9 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 2bd50b9)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/Config.java
#	fe/fe-core/src/main/java/com/starrocks/sql/ast/RefreshSchemeClause.java
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java
@mergify mergify bot mentioned this pull request Dec 15, 2023
Closed
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Dec 16, 2023
@mergify @murphyatwork
[Enhancement] add a switch to control default refresh immediate (back…
0bf0532 
…port #37093) (#37157)

Signed-off-by: Murphy <[email protected]>
Signed-off-by: Murphy <[email protected]>
Co-authored-by: Murphy <[email protected]>
Co-authored-by: Murphy <[email protected]>
murphyatwork added a commit that referenced this pull request Dec 18, 2023
@murphyatwork
[Enhancement] add a switch to control default refresh immediate (#37093)
fe8840b 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 2bd50b9)
murphyatwork added a commit that referenced this pull request Dec 18, 2023
@murphyatwork
[Enhancement] add a switch to control default refresh immediate (#37093)
e26f905 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 2bd50b9)
Signed-off-by: Murphy <[email protected]>

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/Config.java
#	fe/fe-core/src/main/java/com/starrocks/sql/ast/RefreshSchemeDesc.java
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java
wanpengfei-git pushed a commit that referenced this pull request Dec 18, 2023
@mergify @murphyatwork
[Enhancement] add a switch to control default refresh immediate (back…
525bf36 
…port #37093) (#37158)

Co-authored-by: Murphy <[email protected]>
murphyatwork added a commit that referenced this pull request Dec 21, 2023
@mergify @murphyatwork
[Enhancement] add a switch to control default refresh immediate (back…
f62729e 
…port #37093) (#37156)

Co-authored-by: Murphy <[email protected]>
Zhangg7723 pushed a commit to Zhangg7723/starrocks that referenced this pull request Dec 26, 2023
@murphyatwork @Zhangg7723
[Enhancement] add a switch to control default refresh immediate (Star…
d0f1ea1 
…Rocks#37093)

Signed-off-by: Murphy <[email protected]>
Signed-off-by: 张敢 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@packy92 packy92 packy92 approved these changes

@LiShuMing LiShuMing LiShuMing approved these changes

@satanson satanson satanson approved these changes

Assignees

@murphyatwork murphyatwork

Labels
3.0 3.1 3.2 backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@murphyatwork @satanson @LiShuMing @packy92 @wangruin