Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support transaction_read_only compatible with mysql #37249

Merged
merged 2 commits into from
Dec 19, 2023
Merged

[Enhancement] Support transaction_read_only compatible with mysql #37249

merged 2 commits into from
Dec 19, 2023

Conversation

Astralidea
Copy link
Contributor

@Astralidea Astralidea commented Dec 18, 2023

Why I'm doing:
The transaction_read_only parameter was introduced in mysql version 5.7.20. When users set mysql to a higher version, some BI may report an error.

What I'm doing:
add transaction_read_only and tx_read_only.

Fixes #37243

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Astralidea <[email protected]>
Copy link

sonarcloud bot commented Dec 18, 2023

Copy link

[FE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/SessionVariable.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@Astralidea Astralidea enabled auto-merge (squash) December 19, 2023 01:53
@Astralidea Astralidea merged commit 64ecbc5 into StarRocks:main Dec 19, 2023
45 checks passed
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Dec 19, 2023
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Dec 19, 2023
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Dec 19, 2023
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Dec 19, 2023
Copy link
Contributor

mergify bot commented Dec 19, 2023

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 19, 2023

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 19, 2023

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 19, 2023

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 19, 2023
mergify bot pushed a commit that referenced this pull request Dec 19, 2023
mergify bot pushed a commit that referenced this pull request Dec 19, 2023
mergify bot pushed a commit that referenced this pull request Dec 19, 2023
wanpengfei-git pushed a commit that referenced this pull request Dec 19, 2023
wanpengfei-git pushed a commit that referenced this pull request Dec 19, 2023
wanpengfei-git pushed a commit that referenced this pull request Dec 19, 2023
Astralidea added a commit that referenced this pull request Dec 21, 2023
Zhangg7723 pushed a commit to Zhangg7723/starrocks that referenced this pull request Dec 26, 2023
chaoyli pushed a commit to chaoyli/starrocks that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbeaver + msyql driver 8 connects to SR and encounters this error when executing
5 participants