[BugFix] fix enable sync publish when clone #37398

luohaha · 2023-12-19T21:24:36Z

Why I'm doing:
In previous PR #27055 , we add config enable_sync_publish. When it is true, BE will return publish version request success until all version is queryable.

But when clone happen, BE report both version and max_readable_version to FE in finish clone request, and FE will use version instead of max_readable_version to update replica version, so it will broken the rule that enable_sync_publish define, because version may not queryable yet.

What I'm doing:
Using max_readable_version instead of version to update replica version when clone finish.

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Signed-off-by: luohaha <[email protected]>

sonarcloud · 2023-12-21T02:35:31Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2023-12-21T03:54:47Z

[FE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/clone/TabletSchedCtx.java	4	4	100.00%	[]

github-actions · 2023-12-21T03:55:22Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2023-12-21T06:37:32Z

@Mergifyio backport branch-3.2

github-actions · 2023-12-21T06:37:36Z

@Mergifyio backport branch-3.0

mergify · 2023-12-21T06:37:36Z

backport branch-3.2

✅ Backports have been created

#37511 [BugFix] fix enable sync publish when clone (backport #37398) has been created for branch branch-3.2

mergify · 2023-12-21T06:37:38Z

backport branch-3.1

✅ Backports have been created

#37512 [BugFix] fix enable sync publish when clone (backport #37398) has been created for branch branch-3.1

github-actions · 2023-12-21T06:37:38Z

@Mergifyio backport branch-2.5

mergify · 2023-12-21T06:37:41Z

backport branch-3.0

✅ Backports have been created

#37513 [BugFix] fix enable sync publish when clone (backport #37398) has been created for branch branch-3.0

mergify · 2023-12-21T06:37:43Z

backport branch-2.5

✅ Backports have been created

#37514 [BugFix] fix enable sync publish when clone (backport #37398) has been created for branch branch-2.5

Why I'm doing: In previous PR #27055 , we add config enable_sync_publish. When it is true, BE will return publish version request success until all version is queryable. But when clone happen, BE report both version and max_readable_version to FE in finish clone request, and FE will use version instead of max_readable_version to update replica version, so it will broken the rule that enable_sync_publish define, because version may not queryable yet. What I'm doing: Using max_readable_version instead of version to update replica version when clone finish. Signed-off-by: luohaha <[email protected]> (cherry picked from commit 575e644)

sevev · 2023-12-21T08:18:12Z

@mergify backport branch-2.5-bx

mergify · 2023-12-21T08:18:38Z

backport branch-2.5-bx

✅ Backports have been created

#37543 [BugFix] fix enable sync publish when clone (backport #37398) has been created for branch branch-2.5-bx

Why I'm doing: In previous PR #27055 , we add config enable_sync_publish. When it is true, BE will return publish version request success until all version is queryable. But when clone happen, BE report both version and max_readable_version to FE in finish clone request, and FE will use version instead of max_readable_version to update replica version, so it will broken the rule that enable_sync_publish define, because version may not queryable yet. What I'm doing: Using max_readable_version instead of version to update replica version when clone finish. Signed-off-by: luohaha <[email protected]> (cherry picked from commit 575e644)

Co-authored-by: Yixin Luo <[email protected]>

Why I'm doing: In previous PR StarRocks#27055 , we add config enable_sync_publish. When it is true, BE will return publish version request success until all version is queryable. But when clone happen, BE report both version and max_readable_version to FE in finish clone request, and FE will use version instead of max_readable_version to update replica version, so it will broken the rule that enable_sync_publish define, because version may not queryable yet. What I'm doing: Using max_readable_version instead of version to update replica version when clone finish. Signed-off-by: luohaha <[email protected]> Signed-off-by: 张敢 <[email protected]>

Co-authored-by: Yixin Luo <[email protected]> (cherry picked from commit 401dea6)

#37512) (#38282) Signed-off-by: Yixin Luo <[email protected]>

github-actions bot added the title needs [type] label Dec 19, 2023

mergify bot assigned luohaha Dec 19, 2023

luohaha requested review from decster and sevev December 19, 2023 21:26

luohaha force-pushed the fix-sync-publish branch from 7caff6b to 1c8708e Compare December 19, 2023 22:17

luohaha changed the title ~~[Bugfix] fix enable sync publish when clone~~ [BugFix] fix enable sync publish when clone Dec 19, 2023

github-actions bot added 3.2 3.1 3.0 2.5 and removed title needs [type] labels Dec 19, 2023

sevev previously approved these changes Dec 20, 2023

View reviewed changes

decster previously approved these changes Dec 20, 2023

View reviewed changes

luohaha force-pushed the fix-sync-publish branch from 1c8708e to c71eb9a Compare December 20, 2023 04:13

luohaha dismissed stale reviews from sevev and decster via c8447e3 December 20, 2023 18:15

luohaha force-pushed the fix-sync-publish branch from c8447e3 to f458678 Compare December 20, 2023 18:24

[BugFix] fix enable sync publish when clone

c97c2ca

Signed-off-by: luohaha <[email protected]>

luohaha force-pushed the fix-sync-publish branch from f458678 to c97c2ca Compare December 20, 2023 23:32

sevev previously approved these changes Dec 21, 2023

View reviewed changes

luohaha dismissed sevev’s stale review via fef577a December 21, 2023 02:24

fix ut

6331fba

Signed-off-by: luohaha <[email protected]>

luohaha force-pushed the fix-sync-publish branch from fef577a to 6331fba Compare December 21, 2023 02:27

sevev approved these changes Dec 21, 2023

View reviewed changes

decster approved these changes Dec 21, 2023

View reviewed changes

decster merged commit 575e644 into StarRocks:main Dec 21, 2023
45 checks passed

github-actions bot removed the 3.1 label Dec 21, 2023

github-actions bot removed the 3.0 label Dec 21, 2023

github-actions bot removed the 2.5 label Dec 21, 2023

This was referenced Dec 21, 2023

[BugFix] fix enable sync publish when clone (backport #37398) #37511

Merged

[BugFix] fix enable sync publish when clone (backport #37398) #37512

Merged

This was referenced Dec 21, 2023

[BugFix] fix enable sync publish when clone (backport #37398) #37513

Merged

[BugFix] fix enable sync publish when clone (backport #37398) #37514

Merged

mergify bot mentioned this pull request Dec 21, 2023

[BugFix] fix enable sync publish when clone (backport #37398) #37543

Merged

sevev pushed a commit that referenced this pull request Dec 21, 2023

[BugFix] fix enable sync publish when clone (backport #37398) (#37543)

2a5cd0d

Co-authored-by: Yixin Luo <[email protected]>

luohaha added a commit that referenced this pull request Dec 21, 2023

[BugFix] fix enable sync publish when clone (backport #37398) (#37511)

021c91b

Co-authored-by: Yixin Luo <[email protected]>

wanpengfei-git pushed a commit that referenced this pull request Dec 21, 2023

[BugFix] fix enable sync publish when clone (backport #37398) (#37512)

401dea6

Co-authored-by: Yixin Luo <[email protected]>

wanpengfei-git pushed a commit that referenced this pull request Dec 21, 2023

[BugFix] fix enable sync publish when clone (backport #37398) (#37513)

56fa02c

Co-authored-by: Yixin Luo <[email protected]>

wanpengfei-git pushed a commit that referenced this pull request Dec 21, 2023

[BugFix] fix enable sync publish when clone (backport #37398) (#37514)

bfdd1eb

Co-authored-by: Yixin Luo <[email protected]>

mergify bot added a commit that referenced this pull request Jan 2, 2024

[BugFix] fix enable sync publish when clone (backport #37398) (#37512)

1875609

Co-authored-by: Yixin Luo <[email protected]> (cherry picked from commit 401dea6)

andyziye pushed a commit that referenced this pull request Jan 3, 2024

[BugFix] fix enable sync publish when clone (backport #37398) (backport

3c0109d

#37512) (#38282) Signed-off-by: Yixin Luo <[email protected]>

wangruin added the backport_ok label Jan 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] fix enable sync publish when clone #37398

[BugFix] fix enable sync publish when clone #37398

luohaha commented Dec 19, 2023 •

edited

Loading

sonarcloud bot commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

mergify bot commented Dec 21, 2023 •

edited

Loading

mergify bot commented Dec 21, 2023 •

edited

Loading

github-actions bot commented Dec 21, 2023

mergify bot commented Dec 21, 2023 •

edited

Loading

mergify bot commented Dec 21, 2023 •

edited

Loading

sevev commented Dec 21, 2023

mergify bot commented Dec 21, 2023 •

edited

Loading

[BugFix] fix enable sync publish when clone #37398

[BugFix] fix enable sync publish when clone #37398

Conversation

luohaha commented Dec 19, 2023 • edited Loading

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarcloud bot commented Dec 21, 2023

Quality Gate passed

github-actions bot commented Dec 21, 2023

[FE Incremental Coverage Report]

file detail

github-actions bot commented Dec 21, 2023

[BE Incremental Coverage Report]

github-actions bot commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

mergify bot commented Dec 21, 2023 • edited Loading

✅ Backports have been created

mergify bot commented Dec 21, 2023 • edited Loading

✅ Backports have been created

github-actions bot commented Dec 21, 2023

mergify bot commented Dec 21, 2023 • edited Loading

✅ Backports have been created

mergify bot commented Dec 21, 2023 • edited Loading

✅ Backports have been created

sevev commented Dec 21, 2023

mergify bot commented Dec 21, 2023 • edited Loading

✅ Backports have been created

luohaha commented Dec 19, 2023 •

edited

Loading

mergify bot commented Dec 21, 2023 •

edited

Loading

mergify bot commented Dec 21, 2023 •

edited

Loading

mergify bot commented Dec 21, 2023 •

edited

Loading

mergify bot commented Dec 21, 2023 •

edited

Loading

mergify bot commented Dec 21, 2023 •

edited

Loading