Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix bug delete empty list partition report an error #37461

Merged
merged 1 commit into from
Dec 21, 2023
Merged

[BugFix] Fix bug delete empty list partition report an error #37461

merged 1 commit into from
Dec 21, 2023

Conversation

Astralidea
Copy link
Contributor

@Astralidea Astralidea commented Dec 20, 2023 •
edited
Loading

Why I'm doing:

for empty list partition table.
delete report an error ERROR 1064 (HY000): Index: 0, Size: 0

What I'm doing:
fix this problem.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/DeleteMgr.java 2 2 100.00% []

@Astralidea Astralidea enabled auto-merge (squash) December 21, 2023 01:46
@Astralidea Astralidea merged commit 3127f5b into StarRocks:main Dec 21, 2023
46 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Dec 21, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 21, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 3.1 label Dec 21, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 21, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Dec 21, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Dec 21, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 21, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 21, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 21, 2023
@Astralidea @mergify
[BugFix] Fix bug delete empty list partition report an error (#37461)
6c7e2d9 
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit 3127f5b)
@mergify mergify bot mentioned this pull request Dec 21, 2023
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Dec 21, 2023
@Astralidea @mergify
[BugFix] Fix bug delete empty list partition report an error (#37461)
71b3399 
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit 3127f5b)
@mergify mergify bot mentioned this pull request Dec 21, 2023
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Dec 21, 2023
@Astralidea @mergify
[BugFix] Fix bug delete empty list partition report an error (#37461)
ed79212 
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit 3127f5b)
@mergify mergify bot mentioned this pull request Dec 21, 2023
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Dec 21, 2023
@Astralidea @mergify
[BugFix] Fix bug delete empty list partition report an error (#37461)
ad7576a 
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit 3127f5b)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/DeleteHandler.java
@mergify mergify bot mentioned this pull request Dec 21, 2023
Closed
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Dec 21, 2023
@mergify @Astralidea
[BugFix] Fix bug delete empty list partition report an error (backport …
d617bbc 
…#37461) (#37485)

Co-authored-by: Felix Li <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Dec 21, 2023
@mergify @Astralidea
[BugFix] Fix bug delete empty list partition report an error (backport …
81845b2 
…#37461) (#37484)

Co-authored-by: Felix Li <[email protected]>
Astralidea added a commit that referenced this pull request Dec 21, 2023
@mergify @Astralidea
[BugFix] Fix bug delete empty list partition report an error (backport …
2ef0940 
…#37461) (#37483)

Co-authored-by: Felix Li <[email protected]>
Zhangg7723 pushed a commit to Zhangg7723/starrocks that referenced this pull request Dec 26, 2023
@Astralidea @Zhangg7723
[BugFix] Fix bug delete empty list partition report an error (StarRoc…
4cd741b 
…ks#37461)

Signed-off-by: Astralidea <[email protected]>
Signed-off-by: 张敢 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABingHuang ABingHuang ABingHuang approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

@zaorangyang zaorangyang zaorangyang approved these changes

Assignees

@Astralidea Astralidea

Labels
3.0 3.1 3.2 backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Astralidea @zaorangyang @gengjun-git @ABingHuang @wangruin