[Enhancement] add switch enable_materialized_view_rewrite_for_insert #37505

murphyatwork · 2023-12-21T05:12:57Z

Why I'm doing:

MV rewrite for insert statement is trivial and dangerous, considering that the InsertPlanner would take the DbLock, and in corner case the rewrite procedure would take a long time
So consider disable it by default

What I'm doing:

Add a switch enable_materialized_view_rewrite_for_insert to enable rewrite for insert statement
Default value is false

Behavior change:

Before: MV rewrite for insert statement is enabled
After: MV rewrite for insert statement is disabled

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java

Signed-off-by: Murphy <[email protected]>

sonarcloud · 2023-12-25T03:21:25Z

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2023-12-25T04:36:48Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2023-12-25T04:36:48Z

[FE Incremental Coverage Report]

✅ pass : 12 / 14 (85.71%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/qe/SessionVariable.java	5	7	71.43%	[3236, 3237]
🔵	com/starrocks/qe/VariableMgr.java	1	1	100.00%	[]
🔵	com/starrocks/sql/InsertPlanner.java	6	6	100.00%	[]

github-actions · 2023-12-25T06:57:09Z

@Mergifyio backport branch-3.2

github-actions · 2023-12-25T06:57:10Z

@Mergifyio backport branch-3.1

github-actions · 2023-12-25T06:57:12Z

@Mergifyio backport branch-3.0

github-actions · 2023-12-25T06:57:13Z

@Mergifyio backport branch-2.5

mergify · 2023-12-25T06:57:31Z

backport branch-3.2

✅ Backports have been created

#37708 [Enhancement] add switch enable_materialized_view_rewrite_for_insert (backport #37505) has been created for branch branch-3.2 but encountered conflicts

mergify · 2023-12-25T06:57:33Z

backport branch-3.1

✅ Backports have been created

#37709 [Enhancement] add switch enable_materialized_view_rewrite_for_insert (backport #37505) has been created for branch branch-3.1 but encountered conflicts

mergify · 2023-12-25T06:57:34Z

backport branch-3.0

✅ Backports have been created

#37710 [Enhancement] add switch enable_materialized_view_rewrite_for_insert (backport #37505) has been created for branch branch-3.0 but encountered conflicts

mergify · 2023-12-25T06:57:36Z

backport branch-2.5

✅ Backports have been created

#37711 [Enhancement] add switch enable_materialized_view_rewrite_for_insert (backport #37505) has been created for branch branch-2.5 but encountered conflicts

…37505) Signed-off-by: Murphy <[email protected]> (cherry picked from commit 1996cb1) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvRewriteTest.java

…37505) Signed-off-by: Murphy <[email protected]> (cherry picked from commit 1996cb1) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java # fe/fe-core/src/main/java/com/starrocks/sql/InsertPlanner.java # fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvRewriteTest.java

…37505) Signed-off-by: Murphy <[email protected]> (cherry picked from commit 1996cb1) Signed-off-by: Murphy <[email protected]> # Conflicts: # fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvRewriteTest.java

…37505) Signed-off-by: Murphy <[email protected]> (cherry picked from commit 1996cb1) Signed-off-by: Murphy <[email protected]> # Conflicts: # fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java # fe/fe-core/src/main/java/com/starrocks/sql/InsertPlanner.java # fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvRewriteTest.java

…(backport #37505) (#37708) Co-authored-by: Murphy <[email protected]>

…(backport #37505) (#37710) Co-authored-by: Murphy <[email protected]>

…(backport #37505) (#37709) Co-authored-by: Murphy <[email protected]>

…(backport #37505) (#37711) Co-authored-by: Murphy <[email protected]>

…tarRocks#37505) Signed-off-by: Murphy <[email protected]> Signed-off-by: 张敢 <[email protected]>

starrocks-cr bot reviewed Dec 21, 2023

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java Show resolved Hide resolved

mergify bot assigned murphyatwork Dec 21, 2023

github-actions bot added 3.2 3.1 3.0 2.5 labels Dec 21, 2023

kangkaisen previously approved these changes Dec 21, 2023

View reviewed changes

murphyatwork dismissed kangkaisen’s stale review via 5747349 December 21, 2023 07:34

murphyatwork force-pushed the murphy_switch_rewrite_for_insert branch from 5747349 to 539e1c3 Compare December 25, 2023 03:05

murphyatwork requested review from a team as code owners December 25, 2023 03:05

murphyatwork added 3 commits December 25, 2023 11:11

add switch enable_materialized_view_rewrite_for_insert

b2a04e0

Signed-off-by: Murphy <[email protected]>

fix

6a20930

Signed-off-by: Murphy <[email protected]>

fix

47a30a4

Signed-off-by: Murphy <[email protected]>

murphyatwork force-pushed the murphy_switch_rewrite_for_insert branch from 539e1c3 to 47a30a4 Compare December 25, 2023 03:11

kangkaisen approved these changes Dec 25, 2023

View reviewed changes

LiShuMing approved these changes Dec 25, 2023

View reviewed changes

github-actions bot added the behavior_changed label Dec 25, 2023

ABingHuang approved these changes Dec 25, 2023

View reviewed changes

murphyatwork merged commit 1996cb1 into StarRocks:main Dec 25, 2023
63 of 66 checks passed

github-actions bot removed the 3.2 label Dec 25, 2023

github-actions bot removed the 3.1 label Dec 25, 2023

github-actions bot removed the 3.0 label Dec 25, 2023

github-actions bot removed the 2.5 label Dec 25, 2023

This was referenced Dec 25, 2023

[Enhancement] add switch enable_materialized_view_rewrite_for_insert (backport #37505) #37708

Merged

[Enhancement] add switch enable_materialized_view_rewrite_for_insert (backport #37505) #37709

Merged

mergify bot mentioned this pull request Dec 25, 2023

[Enhancement] add switch enable_materialized_view_rewrite_for_insert (backport #37505) #37710

Merged

18 tasks

mergify bot mentioned this pull request Dec 25, 2023

[Enhancement] add switch enable_materialized_view_rewrite_for_insert (backport #37505) #37711

Merged

18 tasks

wanpengfei-git pushed a commit that referenced this pull request Dec 25, 2023

[Enhancement] add switch enable_materialized_view_rewrite_for_insert …

d6a5788

…(backport #37505) (#37708) Co-authored-by: Murphy <[email protected]>

github-actions bot added the 3.2-merged label Dec 25, 2023

wanpengfei-git pushed a commit that referenced this pull request Dec 25, 2023

[Enhancement] add switch enable_materialized_view_rewrite_for_insert …

a4b27d9

…(backport #37505) (#37710) Co-authored-by: Murphy <[email protected]>

github-actions bot added the 3.0-merged label Dec 25, 2023

wanpengfei-git pushed a commit that referenced this pull request Dec 25, 2023

[Enhancement] add switch enable_materialized_view_rewrite_for_insert …

94918df

…(backport #37505) (#37709) Co-authored-by: Murphy <[email protected]>

github-actions bot added the 3.1-merged label Dec 25, 2023

wanpengfei-git pushed a commit that referenced this pull request Dec 25, 2023

[Enhancement] add switch enable_materialized_view_rewrite_for_insert …

2838952

…(backport #37505) (#37711) Co-authored-by: Murphy <[email protected]>

github-actions bot added the 2.5-merged label Dec 25, 2023

Zhangg7723 pushed a commit to Zhangg7723/starrocks that referenced this pull request Dec 26, 2023

[Enhancement] add switch enable_materialized_view_rewrite_for_insert (S…

46d24fd

…tarRocks#37505) Signed-off-by: Murphy <[email protected]> Signed-off-by: 张敢 <[email protected]>

wangruin added the backport_ok label Jan 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] add switch enable_materialized_view_rewrite_for_insert #37505

[Enhancement] add switch enable_materialized_view_rewrite_for_insert #37505

murphyatwork commented Dec 21, 2023 •

edited

Loading

sonarcloud bot commented Dec 25, 2023

github-actions bot commented Dec 25, 2023

github-actions bot commented Dec 25, 2023

github-actions bot commented Dec 25, 2023

github-actions bot commented Dec 25, 2023

github-actions bot commented Dec 25, 2023

github-actions bot commented Dec 25, 2023

mergify bot commented Dec 25, 2023 •

edited

Loading

mergify bot commented Dec 25, 2023 •

edited

Loading

mergify bot commented Dec 25, 2023 •

edited

Loading

mergify bot commented Dec 25, 2023 •

edited

Loading

[Enhancement] add switch enable_materialized_view_rewrite_for_insert #37505

[Enhancement] add switch enable_materialized_view_rewrite_for_insert #37505

Conversation

murphyatwork commented Dec 21, 2023 • edited Loading

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarcloud bot commented Dec 25, 2023

Quality Gate passed

github-actions bot commented Dec 25, 2023

[BE Incremental Coverage Report]

github-actions bot commented Dec 25, 2023

[FE Incremental Coverage Report]

file detail

github-actions bot commented Dec 25, 2023

github-actions bot commented Dec 25, 2023

github-actions bot commented Dec 25, 2023

github-actions bot commented Dec 25, 2023

mergify bot commented Dec 25, 2023 • edited Loading

✅ Backports have been created

mergify bot commented Dec 25, 2023 • edited Loading

✅ Backports have been created

mergify bot commented Dec 25, 2023 • edited Loading

✅ Backports have been created

mergify bot commented Dec 25, 2023 • edited Loading

✅ Backports have been created

murphyatwork commented Dec 21, 2023 •

edited

Loading

mergify bot commented Dec 25, 2023 •

edited

Loading

mergify bot commented Dec 25, 2023 •

edited

Loading

mergify bot commented Dec 25, 2023 •

edited

Loading

mergify bot commented Dec 25, 2023 •

edited

Loading