[BugFix] Fix loadAlterJob failed when upgrade from version smaller than 3.1.2 #38172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gengjun-git <[email protected]>
HangyuanLiu
previously approved these changes
Dec 29, 2023
trueeyu
reviewed
Dec 29, 2023
| @@ -1794,7 +1794,10 @@ public void loadHeaderV2(DataInputStream dis) throws IOException { | |||
|
|
|||
| public long loadAlterJob(DataInputStream dis, long checksum) throws IOException { | |||
| long newChecksum = checksum; | |||
| for (AlterJobV2.JobType type : AlterJobV2.JobType.values()) { | |||
| List<AlterJobV2.JobType> types = Lists.newArrayList(AlterJobV2.JobType.ROLLUP, | |||
There was a problem hiding this comment.
Why create a new list every time I execute it?
trueeyu
previously approved these changes
Dec 29, 2023
Signed-off-by: gengjun-git <[email protected]>
gengjun-git
dismissed stale reviews from trueeyu and HangyuanLiu
via
2994de0
Signed-off-by: gengjun-git <[email protected]>
nshangyiming
previously approved these changes
Dec 29, 2023
Astralidea
approved these changes
Dec 29, 2023
HangyuanLiu
approved these changes
Dec 29, 2023
nshangyiming
approved these changes
Dec 29, 2023
[FE Incremental Coverage Report]❌ fail : 0 / 2 (00.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
JobType.OPTIMIZEis added in version 3.2, it will cause the dislocation of image read.What I'm doing:
Only read the alter jobs of type:
ROLLUP,SCHEMA_CHANGE,DECOMMISSION_BACKEND. The newly added typeJobType.OPTIMIZEwill be saved into new image format, and there is no compatibility issues in this format.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: