Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix QueryContextManager clear_thread crash #50459

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Aug 30, 2024

introduced by #47868

*** Aborted at 1724997275 (unix time) try "date -d @1724997275" if you are using GNU date ***
PC: @          0x5debccb starrocks::pipeline::QueryContextManager::_clean_slot_unlocked(unsigned long, std::vector<std::shared_ptr<starrocks::pipeline::QueryContext>, std::allocator<std::shared_ptr<starrocks::pipeline::QueryContext> > >&)
*** SIGSEGV (@0x68) received by PID 6669 (TID 0x7f1959fe6640) from PID 104; stack trace: ***
    @     0x7f19793aaf68 (/usr/lib/x86_64-linux-gnu/libc.so.6 (deleted)+0x99f67)
    @          0xefd0d19 google::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*)
    @     0x7f197a3ae916 os::Linux::chained_handler(int, siginfo_t*, void*)
    @     0x7f197a3b460b JVM_handle_linux_signal
    @     0x7f197a3a746c signalHandler(int, siginfo_t*, void*)
    @     0x7f1979353520 (/usr/lib/x86_64-linux-gnu/libc.so.6 (deleted)+0x4251f)
    @          0x5debccb starrocks::pipeline::QueryContextManager::_clean_slot_unlocked(unsigned long, std::vector<std::shared_ptr<starrocks::pipeline::QueryContext>, std::allocator<std::shared_ptr<starrocks::pipeline::QueryContext> > >&)
    @          0x5debf27 starrocks::pipeline::QueryContextManager::_clean_query_contexts()
    @          0x5dec191 starrocks::pipeline::QueryContextManager::_clean_func(starrocks::pipeline::QueryContextManager*)
    @          0x5df245b std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (*)(starrocks::pipeline::QueryContextManager*), starrocks::pipeline::QueryContextManager*> > >::_M_run()
    @         0x115c1d44 execute_native_thread_routine
    @     0x7f19793a5b43 (/usr/lib/x86_64-linux-gnu/libc.so.6 (deleted)+0x94b42)
    @     0x7f1979437a00 (/usr/lib/x86_64-linux-gnu/libc.so.6 (deleted)+0x1269ff)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

introduced by StarRocks#47868

```
*** Aborted at 1724997275 (unix time) try "date -d @1724997275" if you are using GNU date ***
PC: @          0x5debccb starrocks::pipeline::QueryContextManager::_clean_slot_unlocked(unsigned long, std::vector<std::shared_ptr<starrocks::pipeline::QueryContext>, std::allocator<std::shared_ptr<starrocks::pipeline::QueryContext> > >&)
*** SIGSEGV (@0x68) received by PID 6669 (TID 0x7f1959fe6640) from PID 104; stack trace: ***
    @     0x7f19793aaf68 (/usr/lib/x86_64-linux-gnu/libc.so.6 (deleted)+0x99f67)
    @          0xefd0d19 google::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*)
    @     0x7f197a3ae916 os::Linux::chained_handler(int, siginfo_t*, void*)
    @     0x7f197a3b460b JVM_handle_linux_signal
    @     0x7f197a3a746c signalHandler(int, siginfo_t*, void*)
    @     0x7f1979353520 (/usr/lib/x86_64-linux-gnu/libc.so.6 (deleted)+0x4251f)
    @          0x5debccb starrocks::pipeline::QueryContextManager::_clean_slot_unlocked(unsigned long, std::vector<std::shared_ptr<starrocks::pipeline::QueryContext>, std::allocator<std::shared_ptr<starrocks::pipeline::QueryContext> > >&)
    @          0x5debf27 starrocks::pipeline::QueryContextManager::_clean_query_contexts()
    @          0x5dec191 starrocks::pipeline::QueryContextManager::_clean_func(starrocks::pipeline::QueryContextManager*)
    @          0x5df245b std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (*)(starrocks::pipeline::QueryContextManager*), starrocks::pipeline::QueryContextManager*> > >::_M_run()
    @         0x115c1d44 execute_native_thread_routine
    @     0x7f19793a5b43 (/usr/lib/x86_64-linux-gnu/libc.so.6 (deleted)+0x94b42)
    @     0x7f1979437a00 (/usr/lib/x86_64-linux-gnu/libc.so.6 (deleted)+0x1269ff)
```

Signed-off-by: stdpain <[email protected]>
@stdpain stdpain requested a review from a team as a code owner August 30, 2024 07:01
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/pipeline/query_context.cpp 1 1 100.00% []

@stdpain stdpain merged commit 7fe3194 into StarRocks:main Aug 30, 2024
75 of 83 checks passed
va-os-commits pushed a commit to va-os-commits/starrocks that referenced this pull request Sep 10, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants