Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] auto change replication_num of system tables (backport #51799) #51885

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 14, 2024

Why I'm doing:

When scale-in the cluster from 3 nodes to 1 node:

  • Since the system tables in _statistics_ database will have 3 replicas, they would stop the scale-in
  • The current solution is to drop this database and recreate it, but which is not safe actually

What I'm doing:

Auto change replication_num of several system tables

  • When scaling out to more than 3 nodes, change the replication_num to 3
  • When scaling in to 1 node, change the replication_num to 1, otherwise scale-in would never succeed

Affected system tables:

  • column_statistics
  • histogram_statistics
  • table_statistic_v1
  • external_column_statistics
  • external_histogram_statistics
  • 3.2: pipe_file_list
  • 3.3: loads_history
  • 3.3: task_run_history

Behavior change:

  • before: the replication_num will only be increased but not decreased
  • now: the replication_num will be increased when scale-out, and decreased when scale-in

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51799 done by [Mergify](https://mergify.com). ## Why I'm doing:

When scale-in the cluster from 3 nodes to 1 node:

  • Since the system tables in _statistics_ database will have 3 replicas, they would stop the scale-in
  • The current solution is to drop this database and recreate it, but which is not safe actually

What I'm doing:

Auto change replication_num of several system tables

  • When scaling out to more than 3 nodes, change the replication_num to 3
  • When scaling in to 1 node, change the replication_num to 1, otherwise scale-in would never succeed

Affected system tables:

  • column_statistics
  • histogram_statistics
  • table_statistic_v1
  • external_column_statistics
  • external_histogram_statistics
  • 3.2: pipe_file_list
  • 3.3: loads_history
  • 3.3: task_run_history

Behavior change:

  • before: the replication_num will only be increased but not decreased
  • now: the replication_num will be increased when scale-out, and decreased when scale-in

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 0c0ea45)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/loadv2/LoadsHistorySyncer.java
#	fe/fe-core/src/main/java/com/starrocks/load/pipe/filelist/RepoCreator.java
#	fe/fe-core/src/main/java/com/starrocks/statistic/StatisticsMetaManager.java
@mergify mergify bot added the conflicts label Oct 14, 2024
Copy link
Contributor Author

mergify bot commented Oct 14, 2024

Cherry-pick of 0c0ea45 has failed:

On branch mergify/bp/branch-3.3/pr-51799
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit 0c0ea45ed1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/load/pipe/filelist/FileListTableRepo.java
	modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/history/TableKeeper.java
	modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/history/TaskRunHistoryTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/statistic/StatisticUtils.java
	modified:   fe/fe-core/src/main/java/com/starrocks/system/SystemInfoService.java
	modified:   fe/fe-core/src/test/java/com/starrocks/load/pipe/filelist/FileListRepoTest.java
	modified:   fe/fe-core/src/test/java/com/starrocks/scheduler/history/TaskRunHistoryTest.java
	new file:   fe/fe-core/src/test/java/com/starrocks/statistic/StatisticUtilsTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/load/loadv2/LoadsHistorySyncer.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/load/pipe/filelist/RepoCreator.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/statistic/StatisticsMetaManager.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Oct 14, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant