Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally hide 'UpToDate' targets #15

Closed
jsvanbethlehem opened this issue Oct 13, 2015 · 8 comments
Closed

Optionally hide 'UpToDate' targets #15

jsvanbethlehem opened this issue Oct 13, 2015 · 8 comments
Assignees
Labels
Milestone

Comments

@jsvanbethlehem
Copy link

It would be very helpful if the BuildVision output window could optionally hide all the 'UpToDate' projects. Currently, when working on large solutions, the stuff that is actually (incrementally) build becomes a bit hard to see between all the up-to-date targets.

Ideally this would be a checkbox on the BuildVision output pane, allowing switching between hiding/showing while a build is running. But it would also make sense maybe to make it a BuildVision option.

@mike03081972
Copy link

Hello,

This option will be very hopefull for me too :)

@StefanKert
Copy link
Owner

So just to elaborate this a bit let me start a discussion on this feature here. Any idea is really appreciated and I´d be really thankful to hear your thoughts on it.

From my point of view we have 3 different solutions on how to solve this. All of them could be combined, but especially 1 and 2 could be implemented together since this is already used for other settings.

1. Adding Option to BuildVision settings

This would result in adding another option to the settings menu. Pretty straight forward.

image

2. Adding Item to Checkbox.

This would be similar to the Show Header Option that is currently available. You can either show up to date projects or not.

image

3. Adding Checkbox to BuildVision Window

Adding a Checkbox to the Mainwindow is also a possible solution, but since we´d really like to keep the window clean and tidy, I think we should take one of the other two options, but I am really open for feedback or arguments that support this one.

Looking forward to the discussion.

@StefanKert StefanKert self-assigned this Jun 23, 2017
@TSchmiedlechner
Copy link
Collaborator

A combination of 1 and 2 would probably be the best solution, since the 'Show Header' option works the same way.

@StefanKert StefanKert added this to the 2.1.0 milestone Aug 10, 2017
@StefanKert
Copy link
Owner

Hey guys,

I added this feature and really wanted to get some feedback on the colors and the visualization. I integrated a separate icon for up-to-date Projects and the count of up-to-date projects basically, this is a blue checkmark, but I am not really confident if this really is a good solution. Really love to hear your thoughts on it.

image

You can now hide projects via a context menu in the grid or through the settings dialog. There is just a little bug that I need to fix that currently leads to wrong alternate background colors.

As I mentioned I really appreciate feedback on this. You can grab the version with the new functionality here: https://github.com/StefanKert/BuildVision/releases/tag/v2.1.0-alpha-3

Thanks in advance!

@JohnyWS
Copy link

JohnyWS commented Oct 18, 2017

Hmm, what about an outlined checkmark instead? Still green, giving the "all OK" feel, but empty to tell you that something is different? (sorta like these: https://www.shutterstock.com/image-vector/choose-mark-check-icon-red-green-578455546)

Love that I can better tell them apart now though!

@StefanKert
Copy link
Owner

StefanKert commented Oct 19, 2017

@JohnyWS thanks for the feedback sir.

image

These are some ideas for icons that we can make use of (https://materialdesignicons.com/ for further possibilities). I really like the double checkmark.

IMO we have to use an icon that doesn´t distract the user too much. The really important icons are the ones that indicate that either action is happening or action is needed:

image

@JohnyWS
Copy link

JohnyWS commented Oct 20, 2017

I like the double checkmark as well, but what does it convey? For me it is that "this node completed, as well as all child nodes". It then gets complicated if there's both up to date and regular built projects underneath, because what should the icon then be?

I think perhaps the following would do the job as to tell that something succeeded or not?

error-and-resolved
(close-octagon-outline, check-circle-outline, check-circle)

Looking at the colored versions, perhaps is should be the outlined version for "UpToDate" and non-outlined for actually building (with or without errors)

Just my 2 cents though. :)

@StefanKert
Copy link
Owner

Your right with your thoughts on the double checkmark. That was the reason why I didn´t use it in the first place.

I don´t think that changing the current icons is a good thing because most users are really used to them. So we´ve to come up with a solution that matches the current icons.

Since I am planning to release the newest version this weekend I think we should close this for now and wait for the feedback from further users and change it later on if it doesn´t work as expected.

Anyway, I really wanted to thank you again for keeping up the discussion and for providing awesome feedback @JohnyWS !

So I am closing this for now, since there is no feedback. If this doesn´t work out for you, please reopen :)

@JohnyWS I will create a separate issue for UI discussions that fits the purpose of this discussion :)

cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants