Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.0.0.104 still has a 'Preview' marker in the header #95

Closed
yannduran opened this issue Apr 21, 2020 · 3 comments
Closed

v3.0.0.104 still has a 'Preview' marker in the header #95

yannduran opened this issue Apr 21, 2020 · 3 comments
Assignees
@StefanKert
Labels
bug

Comments

@yannduran
Copy link

If I understand correctly, v3.0.0.104 is no longer a preview release? There is still a preview marker in the header:

image
@yannduran yannduran changed the title v3.0.0 still has a 'Preview' marker in the header v3.0.0.104 still has a 'Preview' marker in the header Apr 21, 2020
@StefanKert
Copy link
Owner

Indeed! Looks like there is something weird happening in the build pipe. I´ll check that and let you know as soon as it is fixed. Thanks for the heads up

@StefanKert StefanKert self-assigned this May 22, 2020
@StefanKert StefanKert added the bug label May 22, 2020
@yannduran
Copy link
Author

Kein problem! Anytime.

@yannduran
Copy link
Author

I think I found why the Preview marker appears.

In line 43 of ControlView.xaml there's a Border element whose visibility's being bound to PreviewVersion in BuildVisionPaneViewModel.

image

It's possible that the extension isn't being published using the Marketplace configuration, but AFAIK you can't bind to a constant in a viewmodel, only to a property.

HTH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanKert StefanKert

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yannduran @StefanKert