Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sublime.choose_font_dialog when editing font_face setting #393

Open
FichteFoll opened this issue Sep 18, 2023 · 1 comment
Open

Use sublime.choose_font_dialog when editing font_face setting #393

FichteFoll opened this issue Sep 18, 2023 · 1 comment

Comments

@FichteFoll
Copy link
Member

FichteFoll commented Sep 18, 2023

Since build 4156, ST has an sublime.choose_font_dialog API that opens a font choose dialog. Even though ST already provides its own menu entry to edit the main font (Preferences > Font > Choose…), PD could still offer to open the dialog for any Preferences file.

As for how exactly, I'm considering

  • an on_text_command listener that intercepts the command to open the auto complete popup,
  • a phantom with a link similar to the pencil icons we already show in the default preferences,
  • …?
@FichteFoll
Copy link
Member Author

FichteFoll commented Sep 25, 2023

It appears the results of this API aren't exactly exciting when it comes to sub-families. Selecting any font of the Roboto Mono family (… Thin, … Light, … Regular, … Thin Italic, etc.) always results in {'font_face': 'Roboto Mono', 'font_size': 10}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant