From 7535536f8fb61bb3395b72745d0d6128019d8b66 Mon Sep 17 00:00:00 2001 From: Ryan Eberhardt Date: Tue, 30 May 2023 13:13:28 -0700 Subject: [PATCH 1/2] Make deleting metrics source metadata optional --- deploy/helm/sumologic/README.md | 1 + deploy/helm/sumologic/conf/metrics/otelcol/pipeline.yaml | 2 ++ deploy/helm/sumologic/values.yaml | 2 ++ 3 files changed, 5 insertions(+) diff --git a/deploy/helm/sumologic/README.md b/deploy/helm/sumologic/README.md index 041559be96..92d0df3dd7 100644 --- a/deploy/helm/sumologic/README.md +++ b/deploy/helm/sumologic/README.md @@ -91,6 +91,7 @@ The following table lists the configurable parameters of the Sumo Logic chart an | `sumologic.logs.metadata.provider` | Defines logs metadata enrichment provider - `otelcol` or `fluentd`. `otelcol` is the default and is recommended. `fluentd` is deprecated. | `otelcol` | | `sumologic.metrics.enabled` | Set the enabled flag to false for disabling metrics ingestion altogether. | `true` | | `sumologic.metrics.metadata.provider` | Defines metrics metadata enrichment provider - `otelcol` or `fluentd`. `otelcol` is the default and is recommended. `fluentd` is deprecated. | `otelcol` | +| `sumologic.metrics.otelcol.deleteSourceMetadata` | Drop the `_sourceCategory`, `_sourceHost`, and `_sourceName` attributes from metrics; may be desired to reduce cardinality. | `true` | | `sumologic.metrics.otelcol.extraProcessors` | Extra processors configuration for metrics pipeline. See [/docs/collecting-application-metrics.md#metrics-modifications](/docs/collecting-application-metrics.md#metrics-modifications) for more information. | `[]` | | `sumologic.metrics.remoteWriteProxy.enabled` | Enable a load balancing proxy for Prometheus remote writes. [See docs/best-practices.md for more information.](/docs/best-practices.md) | `true` | | `sumologic.metrics.remoteWriteProxy.config.clientBodyBufferSize` | See the [nginx documentation](http://nginx.org/en/docs/http/ngx_http_core_module.html#client_body_buffer_size). Increase if you've also increased samples per send in Prometheus remote write. | `64k` | diff --git a/deploy/helm/sumologic/conf/metrics/otelcol/pipeline.yaml b/deploy/helm/sumologic/conf/metrics/otelcol/pipeline.yaml index 7fbb43a827..47dfd161ae 100644 --- a/deploy/helm/sumologic/conf/metrics/otelcol/pipeline.yaml +++ b/deploy/helm/sumologic/conf/metrics/otelcol/pipeline.yaml @@ -20,7 +20,9 @@ processors: {{- end }} {{- end }} - resource/remove_k8s_pod_pod_name +{{- if .Values.sumologic.metrics.otelcol.deleteSourceMetadata }} - resource/delete_source_metadata +{{- end }} - sumologic_schema - batch - routing diff --git a/deploy/helm/sumologic/values.yaml b/deploy/helm/sumologic/values.yaml index f922390a39..ce1e1379b5 100644 --- a/deploy/helm/sumologic/values.yaml +++ b/deploy/helm/sumologic/values.yaml @@ -438,6 +438,8 @@ sumologic: cpu: 500m otelcol: + ## Drop the _sourceCategory, _sourceHost, and _sourceName attributes from metrics; may be desired to reduce cardinality. + deleteSourceMetadata: true ## Includes additional processors into pipelines. ## It can be used for filtering metrics, renaming, changing metadata and so on. ## This is list of objects, for example: From 171b1d6dbc37ca09f77d9f1e8bec65b4e97acc59 Mon Sep 17 00:00:00 2001 From: Ryan Eberhardt Date: Tue, 30 May 2023 13:25:03 -0700 Subject: [PATCH 2/2] changelog --- .changelog/3072.added.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 .changelog/3072.added.txt diff --git a/.changelog/3072.added.txt b/.changelog/3072.added.txt new file mode 100644 index 0000000000..ece1995f6e --- /dev/null +++ b/.changelog/3072.added.txt @@ -0,0 +1 @@ +configuration to make deleting metrics source metadata optional \ No newline at end of file