Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Autocomplete serialization group (gain -75% of number of SQL requests) #160

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Use Autocomplete serialization group (gain -75% of number of SQL requests) #160

merged 1 commit into from
Dec 8, 2020

Conversation

jacquesbh
Copy link
Member

I have around 720 products.

And this little change did a big change in response time.

image

@jacquesbh jacquesbh requested a review from a team as a code owner November 27, 2020 14:52
@pamil pamil merged commit 62485d9 into Sylius:master Dec 8, 2020
@pamil
Copy link
Contributor

pamil commented Dec 8, 2020

Thank you, Jacques! 🎉

@lchrusciel lchrusciel mentioned this pull request Oct 27, 2021
Merged
Zales0123 added a commit that referenced this pull request Oct 28, 2021
@Zales0123
bug #177 [API] Add missing "Autocomplete" serialization group (lchrus…
1f5c604 
…ciel)

This PR was merged into the 1.1-dev branch.

Discussion
----------

We should add this serialization group to the second product variant endpoint as well. 

Ref. #160

Based on #179

Commits
-------

f26ce33 [API] Add missing "Autocomplete" serialization group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacquesbh @pamil