-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Representative added to invoice shop billing data #134
Representative added to invoice shop billing data #134
Conversation
d29f5e3
to
c95ba3c
Compare
@@ -29,4 +31,6 @@ public function setStreet(?string $street): void; | |||
public function setCity(?string $city): void; | |||
|
|||
public function setPostcode(?string $postcode): void; | |||
|
|||
public function setRepresentative(?string $representative): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setter should be next to getter
@@ -12,5 +12,6 @@ | |||
<field name="city" nullable="true" /> | |||
<field name="postcode" nullable="true" /> | |||
<field name="countryCode" column="country_code" nullable="true" /> | |||
<field name="representative" column="representative" nullable="true" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
column is not needed
@@ -83,4 +91,9 @@ public function setPostcode(?string $postcode): void | |||
{ | |||
$this->postcode = $postcode; | |||
} | |||
|
|||
public function setRepresentative(?string $representative): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as below
Thanks, Bartosz! 🎉 |
No description provided.