Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Representative added to invoice shop billing data #134

Conversation

bartoszpietrzak1994
Copy link
Contributor

No description provided.

@bartoszpietrzak1994 bartoszpietrzak1994 requested a review from a team as a code owner June 4, 2019 07:20
@bartoszpietrzak1994 bartoszpietrzak1994 force-pushed the add-representative-to-invoice-shop-billing-data branch from d29f5e3 to c95ba3c Compare June 4, 2019 07:42
@@ -29,4 +31,6 @@ public function setStreet(?string $street): void;
public function setCity(?string $city): void;

public function setPostcode(?string $postcode): void;

public function setRepresentative(?string $representative): void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setter should be next to getter

@@ -12,5 +12,6 @@
<field name="city" nullable="true" />
<field name="postcode" nullable="true" />
<field name="countryCode" column="country_code" nullable="true" />
<field name="representative" column="representative" nullable="true" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

column is not needed

@@ -83,4 +91,9 @@ public function setPostcode(?string $postcode): void
{
$this->postcode = $postcode;
}

public function setRepresentative(?string $representative): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as below

@GSadee GSadee merged commit c12574b into Sylius:master Jun 4, 2019
@GSadee
Copy link
Member

GSadee commented Jun 4, 2019

Thanks, Bartosz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants