Fix GenerateInvoicesCommand selects order without number

[tom10271]

Supposedly those are cart orders and should not be selected for invoice generation

[firstred]

I can confirm these changes solved the problem for me 😄

Thanks @tom10271 !

[tom10271]

There is still one more thing to fix, I called createQueryBuilder which lived in EntityRepository, but the type set for $orderRepository is OrderRepositoryInterfacemaking CI cannot pass.

Which interface or class should we set?

[Zales0123]

The best solution would be creating a custom OrderRepository, but it requires a custom interface, class, and configuration, which is probably not something we would like to introduce in such a simple fix :/ Maybe you can use one of the existing methods from order repository, like createListQueryBuilder, and then apply the not-null-number criteria on the result? It should do the trick with not much work. Thanks for the contribution!

[tom10271]

I have updated the commit. Please check again. Thank you everyone

[Zales0123]

👍 The last thing that should be done is adding a not-placed order in the background of this feature file to check does this query for sure works as it should work :) Do you think you would be able to do it, @tom10271?

[pamil]

Thank you, @tom10271! 🥇

[diimpp]

That's a might weird solution. Why not check for Order->paymentState instead? Unpaid/cancelled orders have number, but don't qualify to have invoice.