Remove embeddable and replace InvoicingChannel to Channel form Core #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomanhez
force-pushed
the
remove-embeddable
branch
from
162c632 to
146dcb5
Compare
Tomanhez
changed the title
Tomanhez
force-pushed
the
remove-embeddable
branch
3 times, most recently
from
b1be51b to
1863e29
Compare
Tomanhez
changed the title
pamil
reviewed
Oct 18, 2019
| @@ -54,12 +48,10 @@ public function generate(InvoiceInterface $invoice): InvoicePdf | |||
| /** @var string $filename */ | |||
| $filename = str_replace('/', '_', $invoice->number()) . self::FILE_EXTENSION; | |||
|
|
|||
| $channel = $this->channelRepository->findOneByCode($invoice->channel()->getCode()); | |||
Tomanhez
force-pushed
the
remove-embeddable
branch
from
1863e29 to
9f7d32d
Compare
GSadee
reviewed
Oct 22, 2019
Tomanhez
force-pushed
the
remove-embeddable
branch
from
9f7d32d to
cf620cb
Compare
GSadee
approved these changes
Oct 22, 2019
|
Thank you, Tomasz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.