Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Invoice] Add payment status #246

Merged
merged 4 commits into from
Aug 18, 2021
Merged

[Invoice] Add payment status #246

merged 4 commits into from
Aug 18, 2021

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Aug 11, 2021 •
edited
Loading

Screenshot 2021-08-11 at 13 41 23

Screenshot 2021-08-11 at 13 41 28

@AdamKasp AdamKasp requested a review from a team as a code owner August 11, 2021 11:49
@AdamKasp AdamKasp force-pushed the paid-invoice-flag-on-pdf-and-show branch 5 times, most recently from 36b70ac to 947a774 Compare August 12, 2021 06:28
@AdamKasp AdamKasp force-pushed the paid-invoice-flag-on-pdf-and-show branch from 947a774 to 96a0ee7 Compare August 12, 2021 11:19
@AdamKasp AdamKasp force-pushed the paid-invoice-flag-on-pdf-and-show branch from 96a0ee7 to 61a8f40 Compare August 12, 2021 11:22
lchrusciel
lchrusciel reviewed Aug 12, 2021
View reviewed changes
UPGRADE.md Outdated Show resolved Hide resolved
src/Entity/InvoiceInterface.php Outdated Show resolved Hide resolved
src/Migrations/Version20210811092457.php Outdated Show resolved Hide resolved
src/Migrations/Version20210811092457.php Outdated Show resolved Hide resolved
@AdamKasp AdamKasp force-pushed the paid-invoice-flag-on-pdf-and-show branch from 1d37271 to 839da78 Compare August 12, 2021 13:14
arti0090
arti0090 reviewed Aug 12, 2021
View reviewed changes
UPGRADE.md Outdated Show resolved Hide resolved
src/Entity/InvoiceInterface.php Outdated Show resolved Hide resolved
src/Migrations/Version20210812125029.php Show resolved Hide resolved
lchrusciel
lchrusciel reviewed Aug 12, 2021
View reviewed changes
src/Entity/InvoiceInterface.php Outdated Show resolved Hide resolved
src/Entity/InvoiceInterface.php Show resolved Hide resolved
src/Entity/InvoiceInterface.php Outdated Show resolved Hide resolved
GSadee
GSadee reviewed Aug 16, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I would be for using a boolean flag instead of a state here as this value will be set only once while the invoice is generating and will never change.

features/managing_invoices/seeing_payment_state_on_invoice.feature Outdated Show resolved Hide resolved
features/managing_invoices/seeing_payment_state_on_invoice.feature Outdated Show resolved Hide resolved
features/managing_invoices/seeing_payment_state_on_invoice.feature Outdated Show resolved Hide resolved
src/Resources/config/doctrine/Invoice.orm.xml Outdated Show resolved Hide resolved
@Tomanhez Tomanhez force-pushed the paid-invoice-flag-on-pdf-and-show branch 3 times, most recently from ff94776 to 026817f Compare August 17, 2021 13:54
Arminek
Arminek reviewed Aug 18, 2021
View reviewed changes
features/managing_invoices/seeing_payment_state_on_invoice.feature
And for the billing address of "Mazikeen Lilim" in the "Pacific Coast Hwy", "90806" "Los Angeles", "United States"
And the customer chose "UPS" shipping method with "Cash on Delivery" payment

@ui
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make also an @api for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, we don't have API implemented on this plugin

src/Entity/Invoice.php Show resolved Hide resolved
@arti0090 arti0090 force-pushed the paid-invoice-flag-on-pdf-and-show branch from 026817f to 7c572b4 Compare August 18, 2021 12:03
@arti0090 arti0090 force-pushed the paid-invoice-flag-on-pdf-and-show branch from 7700e72 to b503fff Compare August 18, 2021 12:21
@GSadee GSadee added the Feature New feature proposals. label Aug 18, 2021
@GSadee GSadee changed the title flag paid on invoice show and pdf [Invoice] Add payment status Aug 18, 2021
@GSadee GSadee merged commit b41e34f into master Aug 18, 2021
@GSadee
Copy link
Member

GSadee commented Aug 18, 2021

Thanks, Adam! 🥇

@GSadee GSadee deleted the paid-invoice-flag-on-pdf-and-show branch September 7, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arti0090 arti0090 arti0090 left review comments

@SirDomin SirDomin SirDomin left review comments

@Arminek Arminek Arminek left review comments

@lchrusciel lchrusciel lchrusciel left review comments

@Zales0123 Zales0123 Zales0123 left review comments

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AdamKasp @GSadee @Zales0123 @lchrusciel @Arminek @SirDomin @arti0090 @Tomanhez