Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Support PHP 8.1 #325

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

Rafikooo
Copy link
Contributor

Support PHP 8.1

@Rafikooo Rafikooo requested a review from a team as a code owner April 13, 2022 08:05
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I would open it to 1.11

@lchrusciel lchrusciel changed the base branch from master to 1.11 April 13, 2022 09:29
@lchrusciel lchrusciel changed the base branch from 1.11 to master April 13, 2022 09:29
@lchrusciel lchrusciel changed the base branch from master to 1.11 April 13, 2022 09:30
@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "support-php-8.1" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@GSadee GSadee merged commit 990a3fb into Sylius:1.11 Apr 13, 2022
@GSadee
Copy link
Member

GSadee commented Apr 13, 2022

Thank you, Rafał! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants