Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Flex tool from setup-php action to lock Symfony version #330

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jun 14, 2022

The shivammathur/setup-php action provides Flex as a global tool when setting up the environment. So instead of installing it through an extra step, we can use the resources the action already provides.

Next, setting the SYMFONY_REQUIRE env var is the same as writing the extra.symfony.require key in composer.json.

All told, we can avoid a couple of extra Composer commands by using resources that are already available. It's a minor optimization, but it's one nonetheless.

@mbabker mbabker requested a review from a team as a code owner June 14, 2022 17:50
@loic425
Copy link
Member

loic425 commented Jun 15, 2022

@Zales0123
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-1" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Zales0123 Zales0123 changed the base branch from 1.12 to 1.11 September 2, 2022 07:06
@GSadee GSadee merged commit 14d11ea into Sylius:1.11 Sep 5, 2022
@GSadee
Copy link
Member

GSadee commented Sep 5, 2022

Thank you, Michael! 🎉

@mbabker mbabker deleted the patch-1 branch September 5, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants