Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring supported gateways instead of hardcoding them #175

Merged

Conversation

Zales0123
Copy link
Member

It would much easier to customize supported payment methods. Thanks @loevgaard for the idea!

@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Jan 15, 2020
@Zales0123 Zales0123 requested a review from a team as a code owner January 15, 2020 11:30
Copy link
Contributor

@loevgaard loevgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition :D And btw. it was @igormukhingmailcom's idea and code :)

Copy link
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd expect it to be mentioned in the upgrade file :)

UPGRADE.md Outdated Show resolved Hide resolved
@Zales0123 Zales0123 force-pushed the do-not-hardcode-available-payment-methods branch from d389625 to cebbf6d Compare January 15, 2020 15:02
@lchrusciel lchrusciel merged commit 8b99177 into Sylius:master Jan 15, 2020
@lchrusciel
Copy link
Member

Thanks, Mateusz! 🥇

@Zales0123 Zales0123 deleted the do-not-hardcode-available-payment-methods branch January 15, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants