Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refunds] Disable refund when order is free #180

Merged
merged 2 commits into from
Jan 31, 2020
Merged

[Refunds] Disable refund when order is free #180

merged 2 commits into from
Jan 31, 2020

Conversation

AdamKasp
Copy link
Contributor

Screenshot 2020-01-30 at 13 08 10
Screenshot 2020-01-30 at 13 08 24

@AdamKasp AdamKasp requested a review from a team as a code owner January 30, 2020 12:08
@GSadee GSadee added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Jan 30, 2020
GSadee
GSadee reviewed Jan 30, 2020
View reviewed changes
features/preventing_from_refund_free_order.feature Outdated Show resolved Hide resolved
features/preventing_from_refund_free_order.feature Outdated Show resolved Hide resolved
features/preventing_from_refund_free_order.feature Outdated Show resolved Hide resolved
features/preventing_from_refund_free_order.feature Outdated Show resolved Hide resolved
features/preventing_from_refund_free_order.feature Outdated Show resolved Hide resolved
src/Action/Admin/OrderRefundsListAction.php Outdated Show resolved Hide resolved
src/Resources/translations/flashes.en.yml Outdated Show resolved Hide resolved
tests/Behat/Context/Ui/ManagingOrdersContext.php Outdated Show resolved Hide resolved
@AdamKasp AdamKasp force-pushed the disable-refund-when-order-is-free branch from af8ef1c to 4d51720 Compare January 30, 2020 14:46
@AdamKasp AdamKasp force-pushed the disable-refund-when-order-is-free branch 2 times, most recently from 33e78ad to 6de1faa Compare January 31, 2020 09:36
lchrusciel
lchrusciel approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still wondering if we cannot put blocking logic somewhere to state machine with guards.

src/Checker/OrderRefundingAvailabilityChecker.php Outdated Show resolved Hide resolved
src/Checker/OrderRefundsListAvailabilityChecker.php Outdated Show resolved Hide resolved
@AdamKasp AdamKasp force-pushed the disable-refund-when-order-is-free branch 2 times, most recently from 2e74b41 to 4182ea0 Compare January 31, 2020 09:49
@AdamKasp
Copy link
Contributor Author

I'm still wondering if we cannot put blocking logic somewhere to state machine with guards.

Good idea for some refactor 💯

@AdamKasp AdamKasp force-pushed the disable-refund-when-order-is-free branch from 4182ea0 to 1ea802a Compare January 31, 2020 10:05
@GSadee GSadee merged commit a0e4bf2 into Sylius:master Jan 31, 2020
@GSadee
Copy link
Member

GSadee commented Jan 31, 2020

Thank you, Adam! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomanhez Tomanhez Tomanhez left review comments

@kulczy kulczy kulczy approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdamKasp @GSadee @lchrusciel @kulczy @Tomanhez