Convert RefundPayment state values to lowercase #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diimpp
commented
Mar 4, 2020
diimpp
commented
Mar 4, 2020
| @@ -0,0 +1,13 @@ | |||
| {% | |||
| set viewOptions = { | |||
| completed: { icon: 'adjust', color: 'green' }, | |||
There was a problem hiding this comment.
Colors and icons are re-used from regular payment label. To me it looks better balanced.
diimpp
commented
Mar 4, 2020
| @@ -17,7 +17,7 @@ | |||
| <tr> | |||
| <td>{{ money.format(refund_payment.amount, refund_payment.currencyCode) }}</td> | |||
| <td> | |||
| {% include [('@SyliusRefundPlugin/RefundPayment/Label/State/' ~ refund_payment.state ~ '.html.twig'), '@SyliusUi/Label/_default.html.twig'] with {'value': refund_payment.state} %} | |||
| {% include '@SyliusRefundPlugin/Common/Label/refundPaymentState.html.twig' with {'data': refund_payment.state} %} | |||
There was a problem hiding this comment.
include is redesigned in fashion of SyliusAdmin/SyliusShop paymentState label.
{% if refund_payment.state != 'sylius_refund.ui.completed'|trans %}
I will just leave it here as thinking material :D |
diimpp
force-pushed
the
Issue188_state_machine_lower_case
branch
from
3c61308 to
8e2f070
Compare
lchrusciel
approved these changes
Mar 5, 2020
|
@lchrusciel @Zales0123 hey guys, any questions? Can it be merged? |
lchrusciel
approved these changes
Mar 11, 2020
|
It can be merged, but we need to add it to UPGRADE.md. Can you do it? |
diimpp
force-pushed
the
Issue188_state_machine_lower_case
branch
from
8e2f070 to
083e706
Compare
|
@lchrusciel done |
lchrusciel
approved these changes
Mar 11, 2020
lchrusciel
added
DX
|
Thank you, Dmitri! 🎉 |
|
Great, thank you! :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188
Supersedes #190