-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc refactor #200
Misc refactor #200
Conversation
7045893
to
055fba9
Compare
@lchrusciel Hi, sorry, it's still in work. I've moved PR from draft too early, because travis wasn't building properly, but it was the other issue. |
05f676b
to
ac59e85
Compare
705f3a6
to
33f5676
Compare
@lchrusciel @Zales0123 it's ready for review. Let me know if you have any questions. This PR is in fact 6 unrelated PRs, so please review each commit separately. Only difference is last two commits, because last commit is a supporting hack for phpstan. P.S. There is another problematic code, which is Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Dimnitri,
thanks for your contribution!
It seems ok to go with this implementation, but right now we don't have enough power to do a proper review here and possibly release a new version
@lchrusciel thank you for update. I do plan to change Refund/RefundPayment/CreditMemo mappings drastically, so it may be worth waiting for next PR anyway. Current implementation with Refund/RefundPayment/CreditMemo, which are not related between each other is not usable for my company. We need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very good 👌 Thank you @diimpp for such wonderful work, you're making the world a better place 🖖 🎉
Thank you, Dmitri! 🥇 |
Tried to collect BC changes in single PR.
Fixes #192
References #191
number
unique andissuedAt
non nullable (In doctrine mappings, for the rest of the app it's already holds true)sylius_refund_payment
tosylius_refund_refund_payment
(Table was named incorrectly)customerName
intofirstName
andlastName
(As in Addressing\Model\Address, Customer\Model\Customer, Invoicing\Entity\BillingData)issuedAt
to datetime_immutable (Note, that I've converted CurrentDateTimeInterface to CurrentDateTimeImmutableInterface due to phpstan unability to handle properly \DateTimeInterface in context of \DateTime and \DateTimeImmutable DateTimeInterface can be only ever implemented by DateTimeImmutable and Datetime, nothing else phpstan/phpstan#314 https://phpstan.org/r/d15041c9-a230-4b18-a627-fc859ea00838 )