-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DB] Remove COMMENT
database configuration
#202
Conversation
I would vote to drop this ENUM thing entirely. Isn't used in Sylius, so no reason to use over here. |
@lchrusciel Would you agree to drop ENUM package? I can add PR for that later on. |
I'm in favor of it, but I would like to gather the second vote here. /cc @Zales0123 |
724023f
to
2c25a55
Compare
Dropping the enum -> simplification & consistency -> profit 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can drop the enum in the separate PR, I suppose 👌
Thanks, Łukasz! 🎉 |
@diimpp do you think, you could find time to work on this enum removal? I would like to publish a new version of RefundPlugin and this is one of the changes, that could be included |
@lchrusciel yes, but I think state machine code for Order->state==refunded is broken (Maybe not true, not really tested by me) and there is matter of Refund/RefundPayment/CreditMemo design issue. It's on lower priority for me, but I will check it tomorrow and let you know if I can do it early. |
Therefore, I will probably publish the current state as it is, as some useful refactorings were done already. |
@lchrusciel, it look like a hefty task, many method signatures using this So I would be better to go ahead with my other refactor first and look at this afterwards. Some of the classes, that are using this enum may change drastically. |
No description provided.