Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Credit memos and refund payment appears in different order #240

Merged
merged 7 commits into from
Jan 12, 2021
Merged

[BUG] Credit memos and refund payment appears in different order #240

merged 7 commits into from
Jan 12, 2021

Conversation

clem21
Copy link
Contributor

@clem21 clem21 commented Jan 8, 2021

Fixes #231

@clem21 clem21 requested a review from a team as a code owner January 8, 2021 15:19
@clem21 clem21 force-pushed the credit-memos-and-refund-payment-appears-in-different-order branch 2 times, most recently from 1e2491e to 101b9d0 Compare January 8, 2021 16:24
@clem21
Add return type to CreditMemoRepositoryInterface
87eb341 
Add return type to CreditMemoRepository

Fix errors in CreditMemoRepository

Remove useless line in CreditMemoRepository
@clem21 clem21 force-pushed the credit-memos-and-refund-payment-appears-in-different-order branch from 101b9d0 to 87eb341 Compare January 8, 2021 16:33
arti0090
arti0090 approved these changes Jan 11, 2021
View reviewed changes
tests/Behat/Context/Ui/CreditMemoContext.php Outdated Show resolved Hide resolved
GSadee
GSadee reviewed Jan 11, 2021
View reviewed changes
features/viewing_details_of_credit_memo.feature Outdated Show resolved Hide resolved
features/viewing_details_of_credit_memo.feature Outdated Show resolved Hide resolved
src/Doctrine/ORM/CreditMemoRepository.php Outdated Show resolved Hide resolved
tests/Behat/Page/Admin/CreditMemoDetailsPage.php Outdated Show resolved Hide resolved
tests/Behat/Context/Ui/CreditMemoContext.php Outdated Show resolved Hide resolved
@GSadee GSadee merged commit 9ba209d into Sylius:master Jan 12, 2021
@GSadee
Copy link
Member

GSadee commented Jan 12, 2021

Thanks, Clémence! 🥇

@clem21 clem21 mentioned this pull request Jan 13, 2021
Merged
GSadee added a commit that referenced this pull request Jan 14, 2021
@GSadee
minor #243 [Minor] Clean up behat scenarios (clem21)
0e879c0 
This PR was merged into the 1.0-dev branch.

Discussion
----------

Clean up scenarios from #240 

Commits
-------

c8265d2 Clean up behat scenarios
Tomanhez
Tomanhez reviewed Jan 22, 2021
View reviewed changes
features/seeing_refund_payments_on_admin_order_view.feature
@@ -26,3 +26,4 @@ Feature: Seeing refund payments on admin order view
Scenario: Seeing refund payment on order view
When I view the summary of the order "#00000022"
Then I should see 1 refund payment with status "New"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant blank line

tests/Behat/Context/Ui/CreditMemoContext.php Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomanhez Tomanhez Tomanhez left review comments

@AdamKasp AdamKasp AdamKasp left review comments

@arti0090 arti0090 arti0090 approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreditMemos and RefundPayment appears in different order in admin order summary UI
5 participants
@clem21 @GSadee @AdamKasp @arti0090 @Tomanhez