Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing build #251

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Fix failing build #251

merged 2 commits into from
Jan 29, 2021

Conversation

SirDomin
Copy link
Contributor

Added conflict to api-platform 2.6.
Removed ecs due to BC break.

@SirDomin SirDomin requested a review from a team as a code owner January 29, 2021 10:56
composer.json Outdated Show resolved Hide resolved
},
"scripts": {
"analyse": [
"@composer validate --strict",
"vendor/bin/phpstan.phar analyse -c phpstan.neon -l max src/",
"vendor/bin/ecs check src/ spec/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And just remove this line

@GSadee GSadee merged commit adfec08 into Sylius:master Jan 29, 2021
@GSadee
Copy link
Member

GSadee commented Jan 29, 2021

Thanks, @SirDomin! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants