Refund shipping cost with promotion applied #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKasp
approved these changes
Feb 15, 2021
lchrusciel
approved these changes
Feb 15, 2021
| @@ -31,7 +31,7 @@ | |||
| * This class is not covered by the backward compatibility promise and it will be removed after update Sylius to 1.9. | |||
| * It is a duplication of a logic from Sylius to provide proper adjustments handling. | |||
| */ | |||
| final class OrderShipmentTaxesApplicator implements OrderTaxesApplicatorInterface | |||
| class OrderShipmentTaxesApplicator implements OrderTaxesApplicatorInterface | |||
There was a problem hiding this comment.
It's an unintended change (because this service is not final in Sylius), I've opened the PR to revert that: #256
|
Thanks, Grzegorz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252 and partially fixes (3rd point) #110