Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OrderItemsTaxesApplicator with removed units #260

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Fix OrderItemsTaxesApplicator with removed units #260

merged 1 commit into from
Mar 4, 2021

Conversation

aleho
Copy link
Contributor

@aleho aleho commented Mar 2, 2021

This fixes an undefined offset error caused by holes in ArrayCollection keys after removing units.

Fixes #259

@aleho aleho requested a review from a team as a code owner March 2, 2021 13:25
This fixes an undefined offset error caused by holes in ArrayCollection
keys after removing units.
@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Mar 4, 2021
@GSadee GSadee merged commit e902806 into Sylius:master Mar 4, 2021
@GSadee
Copy link
Member

GSadee commented Mar 4, 2021

Thanks, Alexander! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrderItemsTaxesApplicator breaks when items are removed
2 participants