Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify service definitions of line items converters #271

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Unify service definitions of line items converters #271

merged 1 commit into from
Mar 17, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Mar 17, 2021

Fixes #269

@GSadee GSadee requested a review from a team as a code owner March 17, 2021 11:54
@GSadee GSadee force-pushed the unify-definitions-of-line-items-converters branch 3 times, most recently from a33a141 to 28fb8cb Compare March 17, 2021 12:00
@GSadee GSadee mentioned this pull request Mar 17, 2021
Merged
4 tasks
@GSadee GSadee force-pushed the unify-definitions-of-line-items-converters branch from 28fb8cb to 9761e1d Compare March 17, 2021 12:23
lchrusciel
lchrusciel approved these changes Mar 17, 2021
View reviewed changes
src/Converter/OrderItemUnitLineItemsConverter.php
@@ -13,7 +13,7 @@
use Sylius\RefundPlugin\Provider\TaxRateProviderInterface;
use Webmozart\Assert\Assert;

final class LineItemsConverter implements LineItemsConverterInterface
final class OrderItemUnitLineItemsConverter implements LineItemsConverterInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One day, I would love to fix also this interface (as same definition for two different classes, which expects a different type of refunds)

@lchrusciel lchrusciel merged commit 7e2ce6b into Sylius:master Mar 17, 2021
@lchrusciel
Copy link
Member

Thank you, Grzegorz! 🎉

@GSadee GSadee deleted the unify-definitions-of-line-items-converters branch March 17, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomanhez Tomanhez Tomanhez approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Service ID uses non-existing interface Sylius\RefundPlugin\Converter\ShipmentLineItemsConverterInterface
3 participants
@GSadee @lchrusciel @Tomanhez