Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refunding multiple shipments #273

Merged
merged 5 commits into from
Mar 24, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Mar 23, 2021

Fixes #110

@GSadee GSadee added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Mar 23, 2021
@GSadee GSadee requested a review from a team as a code owner March 23, 2021 13:17
@GSadee GSadee force-pushed the refunding-multiple-shipments branch from 7571e38 to 5092357 Compare March 24, 2021 06:55
$order,
$channel ?? $this->sharedStorage->get('channel'),
$productVariant,
(int) $quantity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If quantity is int from begining, should we rly cast it to int here?

@lchrusciel lchrusciel merged commit 817ff65 into Sylius:master Mar 24, 2021
@lchrusciel
Copy link
Member

Thanks, Grzegorz! 🎉

@GSadee GSadee deleted the refunding-multiple-shipments branch March 25, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with tax and shipments
3 participants