Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bus-unification #288

Merged
merged 5 commits into from
May 19, 2021
Merged

bus-unification #288

merged 5 commits into from
May 19, 2021

Conversation

SirDomin
Copy link
Contributor

No description provided.

@SirDomin SirDomin requested a review from a team as a code owner May 10, 2021 12:07
@SirDomin SirDomin force-pushed the sylius-bus-unification branch 4 times, most recently from 0d97033 to 0d6e271 Compare May 10, 2021 13:03
lchrusciel
lchrusciel reviewed May 10, 2021
View reviewed changes
src/Resources/config/services.xml Outdated Show resolved Hide resolved
src/Resources/config/app/config.yml Outdated Show resolved Hide resolved
@SirDomin SirDomin force-pushed the sylius-bus-unification branch 5 times, most recently from 912afe9 to 7a99839 Compare May 10, 2021 13:50
@SirDomin SirDomin force-pushed the sylius-bus-unification branch from 7a99839 to 2847bb1 Compare May 10, 2021 14:01
@SirDomin SirDomin force-pushed the sylius-bus-unification branch 3 times, most recently from 333123d to d2a1c82 Compare May 12, 2021 15:12
@SirDomin SirDomin force-pushed the sylius-bus-unification branch 3 times, most recently from 98603dd to 7c92950 Compare May 18, 2021 14:24
@SirDomin SirDomin force-pushed the sylius-bus-unification branch from 7c92950 to bd3b80a Compare May 18, 2021 14:28
GSadee
GSadee reviewed May 19, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes of buses should be mentioned in UPGRADE file

@SirDomin SirDomin force-pushed the sylius-bus-unification branch from 8b41145 to f08633a Compare May 19, 2021 10:43
@GSadee GSadee merged commit 46e6f1b into Sylius:master May 19, 2021
@GSadee
Copy link
Member

GSadee commented May 19, 2021

Thank you, @SirDomin! 🎉

@GSadee GSadee mentioned this pull request May 31, 2021
Merged
lchrusciel added a commit that referenced this pull request Jun 1, 2021
@lchrusciel
bug #300 Use explicit bus in handlers configurations (GSadee)
d5b480b 
This PR was merged into the 1.0-dev branch.

Discussion
----------

Continuation of #288 

Commits
-------

4c46421 Use explicit bus in handlers configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamKasp AdamKasp AdamKasp approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@GSadee GSadee GSadee approved these changes

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SirDomin @GSadee @pamil @lchrusciel @AdamKasp