Always create RefundPayment after CreditMemo #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
Bug
GSadee
approved these changes
May 25, 2021
features/not_seeing_refund_payments_and_credit_memos_on_admin_order_view.feature
Outdated
Show resolved
Hide resolved
features/not_seeing_refund_payments_and_credit_memos_on_admin_order_view.feature
Outdated
Show resolved
Hide resolved
arti0090
reviewed
May 25, 2021
features/not_seeing_refund_payments_and_credit_memos_on_admin_order_view.feature
Outdated
Show resolved
Hide resolved
pamil
reviewed
May 25, 2021
features/not_seeing_refund_payments_and_credit_memos_on_admin_order_view.feature
Outdated
Show resolved
Hide resolved
features/not_seeing_refund_payments_and_credit_memos_on_admin_order_view.feature
Outdated
Show resolved
Hide resolved
| string $state, | ||
| int $paymentMethodId | ||
| ): RefundPaymentInterface { | ||
| if (file_exists(self::FAILED_FILE)) { |
There was a problem hiding this comment.
I guess we should delete that file on __construct to make sure that we're always starting from the same point. Eg. if the app breaks between failRefundPaymentCreation and createWithData, we're left in an incorrect state.
There was a problem hiding this comment.
Apparently, it does not work as expected :/ The constructor is called twice and removes the file unnecessarily. I've added a @AfterScenario hook to the context, to do the trick 🖖
AdamKasp
approved these changes
May 26, 2021
Zales0123
force-pushed
the
create-credit-memos-and-refund-payments-synchronously
branch
2 times, most recently
from
d1f320b to
f12bc21
Compare
Zales0123
force-pushed
the
create-credit-memos-and-refund-payments-synchronously
branch
from
f12bc21 to
90db258
Compare
GSadee
approved these changes
May 26, 2021
|
Thank you, Mateusz! 🥇 |
Zales0123
deleted the
create-credit-memos-and-refund-payments-synchronously
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solves #91
With the current implementation, both CreditMemo and RefundPayment are generated separately, which can results in a situation when one of them exists and the other does not. With the proposed change, we're protected from such a situation.
For sure, the solution is not perfect. The whole compensation/rollback functionality is based on the DoctrineTransactionMiddleware, which works in this case but does not have to be enough for some more complicated processes. A possible improvement of the proposed architecture would be adding the
prev/compensate/rollbackfunction to theUnitsRefundedProcessStepInterfaceto implement a more mature and reliable saga pattern 🖖