Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use interfaces instead of FQCN as services ids + minor files refactor #302

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Use interfaces instead of FQCN as services ids + minor files refactor #302

merged 1 commit into from
Jun 1, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented May 31, 2021 •
edited
Loading

No description provided.

@GSadee GSadee added Maintenance Configurations, READMEs, releases, etc. DX Issues and PRs aimed at improving Developer eXperience. labels May 31, 2021
@GSadee GSadee requested a review from a team as a code owner May 31, 2021 12:58
@GSadee GSadee force-pushed the using-interfaces-instead-of-fqcn branch from 91d44f9 to 9259537 Compare June 1, 2021 04:47
@GSadee GSadee force-pushed the using-interfaces-instead-of-fqcn branch from 9259537 to 5859e2b Compare June 1, 2021 08:17
@Zales0123 Zales0123 merged commit f11c9e8 into Sylius:master Jun 1, 2021
@Zales0123
Copy link
Member

Thank you, Grzegorz! 🥇

@GSadee GSadee deleted the using-interfaces-instead-of-fqcn branch June 1, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GSadee @Zales0123 @lchrusciel