-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change CustomerBillingData to resource and create via factory #313
Merged
GSadee
merged 5 commits into
Sylius:master
from
arti0090:CustomerBillingData-as-resource
Jun 17, 2021
Merged
Change CustomerBillingData to resource and create via factory #313
GSadee
merged 5 commits into
Sylius:master
from
arti0090:CustomerBillingData-as-resource
Jun 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arti0090
changed the title
[DX]Change CustomerBillingData to resource and create via factory
Change CustomerBillingData to resource and create via factory
Jun 15, 2021
arti0090
force-pushed
the
CustomerBillingData-as-resource
branch
2 times, most recently
from
June 15, 2021 09:06
e18e207
to
e164487
Compare
arti0090
force-pushed
the
CustomerBillingData-as-resource
branch
from
June 15, 2021 09:07
e164487
to
1576c43
Compare
arti0090
force-pushed
the
CustomerBillingData-as-resource
branch
from
June 15, 2021 11:59
49c7162
to
86ecbe2
Compare
SirDomin
approved these changes
Jun 16, 2021
Tomanhez
reviewed
Jun 16, 2021
GSadee
reviewed
Jun 16, 2021
GSadee
approved these changes
Jun 17, 2021
- public function id(): ?int; | ||
+ public function id(); | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Thank you, @arti0090! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.