Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CustomerBillingData to resource and create via factory #313

Merged
merged 5 commits into from
Jun 17, 2021

Conversation

arti0090
Copy link
Contributor

No description provided.

@arti0090 arti0090 added the DX Issues and PRs aimed at improving Developer eXperience. label Jun 15, 2021
@arti0090 arti0090 requested a review from a team as a code owner June 15, 2021 08:45
@arti0090 arti0090 changed the title [DX]Change CustomerBillingData to resource and create via factory Change CustomerBillingData to resource and create via factory Jun 15, 2021
@arti0090 arti0090 force-pushed the CustomerBillingData-as-resource branch 2 times, most recently from e18e207 to e164487 Compare June 15, 2021 09:06
@arti0090 arti0090 force-pushed the CustomerBillingData-as-resource branch from e164487 to 1576c43 Compare June 15, 2021 09:07
@arti0090 arti0090 force-pushed the CustomerBillingData-as-resource branch from 49c7162 to 86ecbe2 Compare June 15, 2021 11:59
src/Entity/CustomerBillingData.php Outdated Show resolved Hide resolved
src/Entity/CustomerBillingData.php Outdated Show resolved Hide resolved
src/Entity/CustomerBillingDataInterface.php Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
- public function id(): ?int;
+ public function id();
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@GSadee GSadee merged commit 2c98749 into Sylius:master Jun 17, 2021
@GSadee
Copy link
Member

GSadee commented Jun 17, 2021

Thank you, @arti0090! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants