Shop billing data as resource #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirDomin
added
the
Enhancement
lchrusciel
approved these changes
Jun 16, 2021
Tomanhez
approved these changes
Jun 16, 2021
GSadee
reviewed
Jun 17, 2021
arti0090
reviewed
Jun 17, 2021
| @@ -117,7 +123,7 @@ private function getToAddress(?ChannelShopBillingData $channelShopBillingData): | |||
| return null; | |||
| } | |||
|
|
|||
| return new ShopBillingData( | |||
| return $this->shopBillingDataFactory->createWithData( | |||
There was a problem hiding this comment.
Maybe a method in factory called createWithChannelShopBillingData ? 😉
See: https://github.com/Sylius/RefundPlugin/pull/313/files#diff-dc7a9ca1a71645aa3eb35cf2d342ab0543241c3b0173c6fe7d6ddf42a641be35R65
It won't block a merge imo - just a suggestion.
There was a problem hiding this comment.
i would leave it as it is now
SirDomin
force-pushed
the
shop-billing-data-as-resource
branch
3 times, most recently
from
7d30efa to
7d987b5
Compare
SirDomin
force-pushed
the
shop-billing-data-as-resource
branch
from
7d987b5 to
d1a6869
Compare
Zales0123
reviewed
Jun 17, 2021
pamil
previously requested changes
Jun 17, 2021
SirDomin
force-pushed
the
shop-billing-data-as-resource
branch
8 times, most recently
from
42e35b0 to
e08c3fb
Compare
Zales0123
reviewed
Jun 18, 2021
SirDomin
force-pushed
the
shop-billing-data-as-resource
branch
3 times, most recently
from
a034208 to
29935c5
Compare
SirDomin
force-pushed
the
shop-billing-data-as-resource
branch
4 times, most recently
from
e18a91c to
d9d84fa
Compare
SirDomin
force-pushed
the
shop-billing-data-as-resource
branch
from
d9d84fa to
1d4e338
Compare
GSadee
reviewed
Jun 21, 2021
Zales0123
reviewed
Jun 21, 2021
Zales0123
reviewed
Jun 21, 2021
SirDomin
force-pushed
the
shop-billing-data-as-resource
branch
from
dc0c514 to
6e24290
Compare
SirDomin
force-pushed
the
shop-billing-data-as-resource
branch
from
6e24290 to
71f26d2
Compare
Zales0123
approved these changes
Jun 22, 2021
|
Thank you, @SirDomin! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.