Improve customization of RefundType #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
force-pushed
the
refactor-refund-type-enum
branch
from
0861bb8 to
e5e9b15
Compare
GSadee
changed the title
AdamKasp
approved these changes
Jul 6, 2021
| @@ -30,31 +32,36 @@ public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $pla | |||
| return 'VARCHAR(256)'; | |||
| } | |||
|
|
|||
| public function convertToPHPValue($value, AbstractPlatform $platform): RefundType | |||
| public function convertToPHPValue($value, AbstractPlatform $platform): RefundTypeInterface | |||
There was a problem hiding this comment.
Suggested change
| public function convertToPHPValue($value, AbstractPlatform $platform): RefundTypeInterface | |
| public function convertToPhpValue($value, AbstractPlatform $platform): RefundTypeInterface |
this way is more camelCase :)
like getId instead getID
There was a problem hiding this comment.
I cannot change the name of this method, it is defined in class below
arti0090
approved these changes
Jul 6, 2021
SirDomin
approved these changes
Jul 7, 2021
|
Thank you, Grzegorz! 🥇 |
AdamKasp
added a commit
to Sylius/Sylius
that referenced
this pull request
Jul 7, 2021
…efund? (GSadee) This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes Sylius/RefundPlugin#279 and waits for Sylius/RefundPlugin#323 | License | MIT  Commits ------- 85b43d3 [Documentation][Cookbook] How to add another type of refund?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #279
Replaces #311