Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve added to parameter to make usage of proper path possible #343

Conversation

TheMilek
Copy link
Member

@TheMilek TheMilek commented Jan 13, 2022

Q A
Branch? 1.0
Bug fix? no
New feature? no
Related tickets PR

In case of need to use a proper path to change the logo of the Credit Memo's we had to add "resolve" to parameter.

@TheMilek TheMilek requested a review from a team as a code owner January 13, 2022 16:14
@TheMilek TheMilek changed the title Resolve added to parameter to make usage of proper path possible [WIP] Resolve added to parameter to make usage of proper path possible Jan 13, 2022
@TheMilek TheMilek force-pushed the resolve-added-to-parameter-to-make-usage-of-proper-path-possible branch from c4cdf55 to 1abd821 Compare January 13, 2022 16:17
@TheMilek TheMilek changed the title [WIP] Resolve added to parameter to make usage of proper path possible Resolve added to parameter to make usage of proper path possible Jan 13, 2022
@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Jan 17, 2022
@GSadee GSadee merged commit 7e0d2df into Sylius:1.0 Jan 17, 2022
@GSadee
Copy link
Member

GSadee commented Jan 17, 2022

Thanks, Kamil! 🎉

GSadee added a commit to Sylius/Sylius that referenced this pull request Jan 17, 2022
This PR was merged into the 1.10 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.10 <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no <!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | [PR](Sylius/RefundPlugin#343)
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

8d691d4 [DOCS] customizing logo in Credit Memo's
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants