Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Symfony flex and Symfony 4 folder structure #250

Closed
pierre-H opened this issue Aug 9, 2018 · 12 comments
Closed

Use Symfony flex and Symfony 4 folder structure #250

pierre-H opened this issue Aug 9, 2018 · 12 comments

Comments

@pierre-H
Copy link

pierre-H commented Aug 9, 2018

Hello !

First, thanks for Sylius : it's a great Framework !

When will you update Sylius to Symfony flex and Symfony 4 folder structure ?
The new system is so easy :)

Thanks !

@pamil
Copy link
Contributor

pamil commented Aug 9, 2018

Great timing, I started to work on that this morning, see Sylius/Sylius#9643! :)

@diimpp
Copy link
Member

diimpp commented Aug 21, 2018

Hi,

are there any plans for this before 1.3, which is I assume planned for late September?

I'm starting a new symfony4/sylius project and wondering if I should tackle it myself locally or start with current version and port to flex dir style later on.

@diimpp
Copy link
Member

diimpp commented Aug 21, 2018

Ok, I guess it's not possible to use flex directory structure until Sylius will remove symfony/symfony dependency.

@teohhanhui
Copy link
Contributor

@diimpp Did you see the linked PR? Sylius/Sylius#9643

@diimpp
Copy link
Member

diimpp commented Aug 21, 2018

@teohhanhui I've did, but Sylius#master still uses symfony/symfony https://github.com/Sylius/Sylius/blob/master/composer.json#L60 dependency, which makes it impossible (To my knowledge) to use flex.

I've tried to install Sylius 1.2 and 1.3@dev on Symfony4-skeleton without success.

@teohhanhui
Copy link
Contributor

Uhh, yes, guess we have to wait for the next PR from @pamil 🥇

@pamil
Copy link
Contributor

pamil commented Aug 22, 2018

@diimpp yeah, symfony/symfony is getting removed from sylius/sylius requirements in a next PR which introduces Flex :)

@Bonobomagno
Copy link

so you did it on 1.2.6?
Do you think to add documentation of suggested way to manage new projects?

@pamil
Copy link
Contributor

pamil commented Aug 29, 2018

The changes will be included in 1.3.0 release, which is scheduled for the very end of September, so there's a plenty of time for polishing and documenting the new flow.

@Bonobomagno
Copy link

Bonobomagno commented Aug 30, 2018

Thanks. this was not clear becouse you are talking about supporting symfony 4 from 1.2.
You closed the symfony 4 support issue on sylius-standard, making me think that the work was done.

I think that will be better to explain that on the readme, something like (still on symfony3)

@teohhanhui
Copy link
Contributor

teohhanhui commented Aug 30, 2018

@Bonobomagno Sylius 1.2 supports Symfony 4.1, but it does not use/support Symfony Flex and is on the old directory structure.

@pamil
Copy link
Contributor

pamil commented Sep 19, 2018

Sylius-Standard is on new directory structure and supporting Symfony Flex now (since #258).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants