Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin][Product] Access the variants management from product edit page #10316

Merged
merged 3 commits into from
Apr 23, 2019
Merged

[Admin][Product] Access the variants management from product edit page #10316

merged 3 commits into from
Apr 23, 2019

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Apr 17, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations?
Related tickets replaces #9785, fixes #9647
License MIT

image

@GSadee GSadee added Feature New feature proposals. Admin AdminBundle related issues and PRs. Roadmap labels Apr 17, 2019
@GSadee GSadee requested a review from a team as a code owner April 17, 2019 10:31
@GSadee GSadee mentioned this pull request Apr 17, 2019
Closed
@GSadee GSadee force-pushed the edit-product-manage-variants branch from f4bbaf7 to 91ad916 Compare April 17, 2019 11:19
@GSadee GSadee force-pushed the edit-product-manage-variants branch from 91ad916 to edb41fe Compare April 17, 2019 13:58
@GSadee GSadee force-pushed the edit-product-manage-variants branch 2 times, most recently from 59be077 to c4b2f0e Compare April 18, 2019 12:21
@GSadee GSadee force-pushed the edit-product-manage-variants branch from c4b2f0e to dc811f5 Compare April 19, 2019 09:34
lchrusciel
lchrusciel reviewed Apr 19, 2019
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we need to mention about a new event in the section about the menu customization

src/Sylius/Bundle/AdminBundle/Menu/ProductUpdateMenuBuilder.php Show resolved Hide resolved
@GSadee
Copy link
Member Author

GSadee commented Apr 19, 2019

@lchrusciel I've updated docs 👌

@Zales0123 Zales0123 merged commit 22b4e45 into Sylius:master Apr 23, 2019
@Zales0123
Copy link
Member

Thank you, Grzegorz! 🎉

@GSadee GSadee deleted the edit-product-manage-variants branch April 23, 2019 11:00
@CoderMaggie CoderMaggie mentioned this pull request May 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomanhez Tomanhez Tomanhez left review comments

@CoderMaggie CoderMaggie CoderMaggie approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shortcut to variants in product edit page
6 participants
@GSadee @Zales0123 @pamil @lchrusciel @CoderMaggie @Tomanhez