[Fixtures] Allow no shipping and payments in fixtures #10618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
Potential Bug
pamil
approved these changes
Aug 23, 2019
lchrusciel
reviewed
Aug 23, 2019
pamil
suggested changes
Aug 23, 2019
pamil
suggested changes
Aug 23, 2019
Zales0123
force-pushed
the
allow-no-shipping-and-payments-in-fixtures
branch
from
8853f06 to
1e69302
Compare
pamil
approved these changes
Aug 23, 2019
|
Thank you, Mateusz! 🥇 |
This was referenced Aug 23, 2019
|
And Igor! 🎉 |
pamil
added a commit
that referenced
this pull request
Aug 26, 2019
…es0123) This PR was merged into the 1.4 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | introduces in #10618 | License | MIT There is no need to skip payment and shipment in order manually, as it's done automatically with [this callback](https://github.com/Sylius/Sylius/blob/60134b783c51c4b9da0b58c5a54482824a8baf8a/src/Sylius/Bundle/CoreBundle/Resources/config/app/state_machine/sylius_order_checkout.yml#L53) 🎉 Commits ------- fbb68f2 [Fixture] Do not skip payments and shipments manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @igormukhingmailcom for your work! It's rebased and refactored now