Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed visibility to make it usable when extending #10756

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Changed visibility to make it usable when extending #10756

merged 1 commit into from
Oct 10, 2019

Conversation

loevgaard
Copy link
Contributor

This method could easily be used when extending the repository, therefore it would make sense to make it protected

Q A
Branch? master
Bug fix? No
New feature? Sort of
BC breaks? No
Deprecations? No
License MIT

@loevgaard
Changed visibility to make it usable when extending
4027b23 
This method could easily be used when extending the repository, therefore it would make sense to make it protected
@loevgaard loevgaard requested a review from a team as a code owner October 10, 2019 13:20
@Zales0123 Zales0123 added the DX Issues and PRs aimed at improving Developer eXperience. label Oct 10, 2019
@pamil pamil merged commit d4d8a6d into Sylius:master Oct 10, 2019
@pamil
Copy link
Contributor

pamil commented Oct 10, 2019

Thank you, Joachim! 🎉

@loevgaard loevgaard deleted the patch-1 branch October 11, 2019 07:07
@loevgaard
Copy link
Contributor Author

My pleasure!

@loevgaard loevgaard mentioned this pull request Dec 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loevgaard @pamil @Zales0123