Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Psalm more aggressive #10814

Merged
merged 15 commits into from
Nov 8, 2019
Merged

Make Psalm more aggressive #10814

merged 15 commits into from
Nov 8, 2019

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Nov 1, 2019

In order to find out places that make the most of our tech debt, we need to make Psalm more aggressive. All suppressed errors should indicate a hotspot with an issue worth addressing.

It'd be easier to review this PR commit by commit.

Based on #10811.

@pamil pamil added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc. labels Nov 1, 2019
@pamil pamil requested a review from a team as a code owner November 1, 2019 18:32
@loic425
Copy link
Member

loic425 commented Nov 6, 2019

@pamil Great, it's a real fight you started here!

@pamil pamil force-pushed the psalm-fight branch 2 times, most recently from 60294a0 to f4b5099 Compare November 6, 2019 18:00
@Zales0123
Copy link
Member

Rebase needed 🚀

@Zales0123 Zales0123 merged commit 9ec0fa3 into Sylius:master Nov 8, 2019
@Zales0123
Copy link
Member

Thanks, Kamil! 🥇

@pamil pamil deleted the psalm-fight branch November 8, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants