-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Psalm more aggressive #10814
Merged
Merged
Make Psalm more aggressive #10814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
added
Enhancement
Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Maintenance
CI configurations, READMEs, releases, etc.
labels
Nov 1, 2019
@pamil Great, it's a real fight you started here! |
pamil
force-pushed
the
psalm-fight
branch
2 times, most recently
from
November 6, 2019 18:00
60294a0
to
f4b5099
Compare
Tomanhez
approved these changes
Nov 7, 2019
Rebase needed 🚀 |
Thanks, Kamil! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Maintenance
CI configurations, READMEs, releases, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to find out places that make the most of our tech debt, we need to make Psalm more aggressive. All suppressed errors should indicate a hotspot with an issue worth addressing.
It'd be easier to review this PR commit by commit.
Based on #10811.