Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Channel] channel types #10860

Merged
merged 4 commits into from
Nov 21, 2019
Merged

[Channel] channel types #10860

merged 4 commits into from
Nov 21, 2019

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Nov 18, 2019 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

Screenshot 2019-11-19 at 16 12 12
Screenshot 2019-11-19 at 16 12 25
Screenshot 2019-11-19 at 18 05 31

@AdamKasp AdamKasp requested a review from a team as a code owner November 18, 2019 10:04
@AdamKasp AdamKasp force-pushed the add-type-of-channel branch 2 times, most recently from 44a818a to 7850498 Compare November 18, 2019 10:09
@AdamKasp AdamKasp force-pushed the add-type-of-channel branch from 7850498 to 2a69d99 Compare November 19, 2019 12:22
@AdamKasp AdamKasp changed the title [Behat][Channel] Scenarios for channel types [Channel] channel types Nov 19, 2019
@AdamKasp AdamKasp changed the title [Channel] channel types [wip][Channel] channel types Nov 19, 2019
@AdamKasp AdamKasp force-pushed the add-type-of-channel branch 2 times, most recently from 76e7234 to 2bc37c3 Compare November 19, 2019 17:04
@AdamKasp AdamKasp changed the title [wip][Channel] channel types [Channel] channel types Nov 19, 2019
@AdamKasp AdamKasp force-pushed the add-type-of-channel branch from 2bc37c3 to e87e457 Compare November 19, 2019 17:12
@GSadee GSadee added Admin AdminBundle related issues and PRs. Feature New feature proposals. labels Nov 20, 2019
@AdamKasp AdamKasp force-pushed the add-type-of-channel branch 2 times, most recently from 7aca651 to e412281 Compare November 20, 2019 13:17
@AdamKasp AdamKasp force-pushed the add-type-of-channel branch from e412281 to 248819a Compare November 21, 2019 10:26
@AdamKasp AdamKasp force-pushed the add-type-of-channel branch from 248819a to 35a2270 Compare November 21, 2019 12:30
@pamil pamil merged commit 2f0c73c into Sylius:master Nov 21, 2019
@pamil
Copy link
Contributor

pamil commented Nov 21, 2019

Thanks, Adam! 🎉

lchrusciel added a commit to lchrusciel/Sylius that referenced this pull request Jan 22, 2020
@lchrusciel
[Admin][Channel] Revert Sylius#10860
300cb0c
@lchrusciel lchrusciel mentioned this pull request Jan 22, 2020
Merged
lchrusciel added a commit to lchrusciel/Sylius that referenced this pull request Jan 22, 2020
@lchrusciel
[Admin][Channel] Revert Sylius#10860
e9ec260
pamil added a commit that referenced this pull request Jan 23, 2020
@pamil
refactor #11053 [Admin][Channel] Revert #10860 (lchrusciel)
0a15430 
This PR was merged into the 1.7-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | reverts #10860
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.6 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set
-->


Commits
-------

e9ec260 [Admin][Channel] Revert #10860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomanhez Tomanhez Tomanhez left review comments

@Zales0123 Zales0123 Zales0123 left review comments

@GSadee GSadee GSadee approved these changes

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdamKasp @pamil @GSadee @Zales0123 @Tomanhez