[Admin][Order] Add resending an order confirmation email #10932
Conversation
GSadee
added
Feature
src/Sylius/Bundle/AdminBundle/Resources/config/routing/order.yml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Action/ResendOrderConfirmationEmailAction.php
Show resolved
Hide resolved
| @@ -47,6 +47,7 @@ | |||
|
|
|||
| {% include '@SyliusAdmin/Order/Show/_payments.html.twig' %} | |||
| {% include '@SyliusAdmin/Order/Show/_shipments.html.twig' %} | |||
| {% include '@SyliusAdmin/Order/Show/_resendEmail.html.twig' %} | |||
There was a problem hiding this comment.
It is just a personal filling, but I would say, that it would be better to add this button next to cancel buttons etc at the top of the page
There was a problem hiding this comment.
It is quite a big button and I've consulted that with @CoderMaggie that this will be a proper place
GSadee
force-pushed
the
resending-order-confirmation
branch
from
7d9cfa4 to
459bc1a
Compare
src/Sylius/Bundle/AdminBundle/EmailManager/OrderEmailManager.php
Outdated
Show resolved
Hide resolved
GSadee
force-pushed
the
resending-order-confirmation
branch
4 times, most recently
from
1db2c65 to
85a0b36
Compare
|
Reaction: I think typically it is more visible in the top (above the customer or maybe the top menu? Here it will be really hidden. |
|
@pjedrzejewski I know, but it's not a common action, but an edge-case. It will not be performed all the time, that's why I've requested placing it on the bottom :) |
GSadee
force-pushed
the
resending-order-confirmation
branch
from
85a0b36 to
d7baba1
Compare
| 'sylius.email.order_confirmation_resent' | ||
| ); | ||
|
|
||
| return new RedirectResponse($request->headers->get('referer')); |
There was a problem hiding this comment.
In the long term, we should think about providing a way to handle these actions in Admin API as well, because right now Admin API and normal Admin panel will drift from each other with the feature list
| {% endblock %} | ||
|
|
||
| {% block content %} | ||
| {% set url = channel.hostname is not null ? 'http://' ~ channel.hostname ~ path('sylius_shop_order_show', {'tokenValue': order.tokenValue, '_locale': localeCode}) : url('sylius_shop_order_show', {'tokenValue': order.tokenValue, '_locale': localeCode}) %} |
There was a problem hiding this comment.
We need to resolve this coupling ASAP
|
Thank you, Grzegorz! 🥇 |
Based on #10936