Api refactor product and order related endpoints #11795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Sep 2, 2020
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | 1.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | part of #11250 based on #11791 |
| License | MIT |
lchrusciel
reviewed
Sep 2, 2020
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Product.xml
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
api-refactor-product-related-endpoints
branch
from
ca700e6 to
7743db2
Compare
AdamKasp
changed the title
AdamKasp
force-pushed
the
api-refactor-product-related-endpoints
branch
8 times, most recently
from
2f2c7e0 to
89d5a6f
Compare
GSadee
reviewed
Sep 7, 2020
src/Sylius/Behat/spec/Service/Converter/IriToShopPathConverterSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/spec/Service/Converter/IriToShopPathConverterSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Adjustment.xml
Outdated
Show resolved
Hide resolved
lchrusciel
reviewed
Sep 7, 2020
src/Sylius/Behat/Resources/config/services/contexts/api/shop.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Adjustment.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Adjustment.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Payment.xml
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
api-refactor-product-related-endpoints
branch
3 times, most recently
from
dc1c548 to
1096d7a
Compare
arti0090
previously requested changes
Sep 8, 2020
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Province.xml
Outdated
Show resolved
Hide resolved
Tomanhez
reviewed
Sep 8, 2020
GSadee
reviewed
Sep 8, 2020
AdamKasp
force-pushed
the
api-refactor-product-related-endpoints
branch
2 times, most recently
from
6559859 to
25c244f
Compare
GSadee
approved these changes
Sep 9, 2020
AdamKasp
force-pushed
the
api-refactor-product-related-endpoints
branch
from
25c244f to
8af7e9e
Compare
AdamKasp
force-pushed
the
api-refactor-product-related-endpoints
branch
from
8af7e9e to
c64233b
Compare
lchrusciel
approved these changes
Sep 9, 2020
| <attribute name="openapi_context"> | ||
| <attribute name="summary">Address cart to given location, logged in Customer does not have to provide an email</attribute> | ||
| <attribute name="summary">Adds Item to cart</attribute> |
| </itemOperation> | ||
| </itemOperations> | ||
|
|
||
| <collectionOperations /> |
|
Thank you, Adam! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.